Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cortexrc race condition #1707

Merged
merged 2 commits into from
Nov 19, 2024
Merged

fix: cortexrc race condition #1707

merged 2 commits into from
Nov 19, 2024

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Nov 19, 2024 •
edited
Loading

Describe Your Changes

  • Use singleton and mutex for accessing cortexrc

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review November 19, 2024 09:59
@namchuai namchuai self-requested a review November 19, 2024 10:50
@vansangpfiev vansangpfiev merged commit 027002f into dev Nov 19, 2024
9 of 10 checks passed
@vansangpfiev vansangpfiev deleted the fix/file-manager-config-yaml-race branch November 19, 2024 10:51
@louis-menlo
Copy link
Contributor

Tested from Jan ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vansangpfiev @louis-menlo @namchuai @sangjanai