Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support user defined engine path #1687

Merged
merged 1 commit into from
Nov 15, 2024
Merged

fix: support user defined engine path #1687

merged 1 commit into from
Nov 15, 2024

Conversation

namchuai
Copy link
Collaborator

Describe Your Changes

  • Support user defined engine path via env ENGINE_PATH

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai force-pushed the j/update-user-defined-engine-path branch from ccf9259 to 481a092 Compare November 15, 2024 01:17
@namchuai namchuai marked this pull request as ready for review November 15, 2024 04:28
@namchuai namchuai requested a review from a team November 15, 2024 04:28
@namchuai namchuai merged commit 3bf5f87 into dev Nov 15, 2024
9 of 10 checks passed
@namchuai namchuai deleted the j/update-user-defined-engine-path branch November 15, 2024 04:50
@louis-menlo louis-menlo mentioned this pull request Nov 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenhoangthuan99 nguyenhoangthuan99 nguyenhoangthuan99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@namchuai @nguyenhoangthuan99