Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect mapper upload engines api #1674

Merged
merged 3 commits into from
Nov 13, 2024
Merged

fix: incorrect mapper upload engines api #1674

merged 3 commits into from
Nov 13, 2024

Conversation

luke-nguyen990
Copy link
Contributor

@luke-nguyen990 luke-nguyen990 commented Nov 13, 2024 •
edited
Loading

Describe Your Changes

  • Engine: load api was mapped to unload api

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@luke-nguyen990 luke-nguyen990 force-pushed the fix/incorrect-mapper-unload-engines branch from 548add9 to 4434391 Compare November 13, 2024 01:47
@luke-nguyen990 luke-nguyen990 marked this pull request as ready for review November 13, 2024 02:01
@vansangpfiev vansangpfiev requested a review from a team November 13, 2024 02:17
@luke-nguyen990 luke-nguyen990 merged commit a6d6be3 into dev Nov 13, 2024
5 checks passed
@luke-nguyen990 luke-nguyen990 deleted the fix/incorrect-mapper-unload-engines branch November 13, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vansangpfiev vansangpfiev vansangpfiev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luke-nguyen990 @vansangpfiev