Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/gemma2 chat template #1657

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Fix/gemma2 chat template #1657

merged 5 commits into from
Nov 11, 2024

Conversation

nguyenhoangthuan99
Copy link
Contributor

@nguyenhoangthuan99 nguyenhoangthuan99 commented Nov 8, 2024 •
edited
Loading

Describe Your Changes

  • Fix chat template renderer for gemma2 model

new chat template

<start_of_turn>user\n{system_message}<end_of_turn>\n<start_of_turn>user\n{prompt}<end_of_turn>\n<start_of_turn>model\n

image

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024 •
edited
Loading

Preview URL: https://ce7e1e8f.cortex-docs.pages.dev

@nguyenhoangthuan99 nguyenhoangthuan99 marked this pull request as ready for review November 8, 2024 07:01
namchuai
namchuai approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ lgtm

@nguyenhoangthuan99 nguyenhoangthuan99 merged commit 7cf62d5 into dev Nov 11, 2024
5 checks passed
@nguyenhoangthuan99 nguyenhoangthuan99 deleted the fix/gemma2-chat-template branch November 11, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

@vansangpfiev vansangpfiev Awaiting requested review from vansangpfiev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nguyenhoangthuan99 @namchuai