Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: some update for engine management #1650

Merged
merged 7 commits into from
Nov 8, 2024
Merged

chore: some update for engine management #1650

merged 7 commits into from
Nov 8, 2024

Conversation

namchuai
Copy link
Collaborator

@namchuai namchuai commented Nov 8, 2024

Describe Your Changes

  • Add indicator when engine version is outdated and can be update in CLI
  • Remove other engines version when update
  • Some improvements

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai requested review from dan-menlo and a team November 8, 2024 02:03
vansangpfiev
vansangpfiev reviewed Nov 8, 2024
View reviewed changes
engine/cli/main.cc Outdated Show resolved Hide resolved
@namchuai namchuai merged commit c7765ec into dev Nov 8, 2024
4 checks passed
@namchuai namchuai deleted the j/update-engine-mng branch November 8, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vansangpfiev vansangpfiev vansangpfiev approved these changes

@dan-menlo dan-menlo Awaiting requested review from dan-menlo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@namchuai @vansangpfiev