Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make cortex-nightly update -v works again #1645

Merged
merged 1 commit into from
Nov 6, 2024
Merged

fix: make cortex-nightly update -v works again #1645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions engine/cli/commands/cortex_upd_cmd.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ std::unique_ptr<system_info_utils::SystemInfo> GetSystemInfoWithUniversal() {
std::string GetNightlyInstallerName(const std::string& v,
const std::string& os_arch) {
const std::string kCortex = "cortex";
std::string version = v == "latest" ? "" : (v + "-");
// Remove 'v' in file name
std::string version = v == "latest" ? "" : (v.substr(1) + "-");
#if defined(__APPLE__) && defined(__MACH__)
return kCortex + "-" + version + os_arch + "-network-installer.pkg";
#elif defined(__linux__)
Expand All @@ -55,7 +56,8 @@ std::string GetNightlyInstallerName(const std::string& v,
// C:\Users\vansa\AppData\Local\Temp\cortex\cortex-windows-amd64-network-installer.exe
std::string GetInstallCmd(const std::string& exe_path) {
#if defined(__APPLE__) && defined(__MACH__)
return "sudo touch /var/tmp/cortex_installer_skip_postinstall && sudo installer "
return "sudo touch /var/tmp/cortex_installer_skip_postinstall && sudo "
"installer "
"-pkg " +
exe_path +
" -target / && sudo rm /var/tmp/cortex_installer_skip_postinstall";
Expand Down
Loading