Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cors #1640

Merged
merged 7 commits into from
Nov 7, 2024
Merged

fix: cors #1640

merged 7 commits into from
Nov 7, 2024

Conversation

namchuai
Copy link
Collaborator

@namchuai namchuai commented Nov 6, 2024 •
edited by gabrielle-ong
Loading

Describe Your Changes

Screenshot 2024-11-06 at 23 26 37

Adding CORS configurations

Get configuration status

Screenshot 2024-11-06 at 23 19 18 #### Update configuration Screenshot 2024-11-06 at 23 20 40 #### HTTP API Screenshot 2024-11-06 at 23 21 56

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024 •
edited
Loading

Preview URL: https://8712b4d3.cortex-docs.pages.dev

@namchuai namchuai marked this pull request as ready for review November 6, 2024 16:17
@namchuai namchuai requested review from dan-menlo and a team November 6, 2024 16:18
@namchuai namchuai merged commit 086de70 into dev Nov 7, 2024
5 checks passed
@namchuai namchuai deleted the j/fix-cors branch November 7, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vansangpfiev vansangpfiev vansangpfiev approved these changes

@dan-menlo dan-menlo Awaiting requested review from dan-menlo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

epic: API and CLI to enable/disable CORS
2 participants
@namchuai @vansangpfiev