Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adding engines docs #1631

Merged
merged 1 commit into from
Nov 5, 2024
Merged

chore: adding engines docs #1631

merged 1 commit into from
Nov 5, 2024

Conversation

namchuai
Copy link
Collaborator

@namchuai namchuai commented Nov 4, 2024

Describe Your Changes

  • Adding docs for engines

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai requested review from gabrielle-ong, dan-menlo and a team November 4, 2024 11:48
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Preview URL: https://153c4963.cortex-docs.pages.dev

gabrielle-ong
gabrielle-ong approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@gabrielle-ong gabrielle-ong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @namchuai for the details! Merging

@gabrielle-ong gabrielle-ong merged commit 5338a78 into dev Nov 5, 2024
1 check passed
@gabrielle-ong gabrielle-ong deleted the j/engines-docs branch November 5, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielle-ong gabrielle-ong gabrielle-ong approved these changes

@dan-menlo dan-menlo Awaiting requested review from dan-menlo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@namchuai @gabrielle-ong