chore: update model's size on import #1630
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This PR updates the model's size on import as supported in the pull request. It includes minor refactoring of file size extension and consolidates features using the std::filesystem API.
Changes made
The provided
git diff
reflects several modifications across multiple files in the project. Here's a concise summary of these changes:gguf_parser.cc
:std::filesystem::file_size
for reliability and simplicity.models.cc
:std::filesystem::file_size
to fetch the file size when importing models, storing this size in themodel_config
.download_service.cc
anddownload_service.h
:GetLocalFileSize
method and replaced its usage withstd::filesystem::file_size
for determining file sizes.download_service.h
file had the method deleted from class specifications.curl_easy_setopt
uses the new size-fetching method directly.These changes simplify and modernize file size handling by leveraging the C++17
<filesystem>
library.