Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove package json root #1585

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix: remove package json root #1585

merged 1 commit into from
Oct 30, 2024

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Oct 30, 2024

Describe Your Changes

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur requested review from namchuai and hiento09 October 30, 2024 09:00
@urmauur urmauur self-assigned this Oct 30, 2024
hiento09
hiento09 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@hiento09 hiento09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@urmauur urmauur merged commit 75cf152 into dev Oct 30, 2024
@urmauur urmauur deleted the fix/remove-package-json branch October 30, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiento09 hiento09 hiento09 approved these changes

@namchuai namchuai namchuai approved these changes

Assignees

@urmauur urmauur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@urmauur @namchuai @hiento09