Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add n_parallel to model yaml config #1571

Merged
merged 2 commits into from
Oct 30, 2024
Merged

fix: add n_parallel to model yaml config #1571

merged 2 commits into from
Oct 30, 2024

Conversation

vansangpfiev
Copy link
Contributor

Describe Your Changes

  • Added n_parallel to model yaml config struct
  • Please note that we also add n_parallel parameter into model.yml in HF

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review October 29, 2024 09:28
@vansangpfiev vansangpfiev requested review from a team and removed request for nguyenhoangthuan99 October 29, 2024 09:28
@vansangpfiev vansangpfiev merged commit 6cda3ee into dev Oct 30, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the fix/n_parrallel branch October 30, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenhoangthuan99 nguyenhoangthuan99 nguyenhoangthuan99 approved these changes

@namchuai namchuai namchuai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vansangpfiev @namchuai @nguyenhoangthuan99