Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash while downloading model #1554

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix: crash while downloading model #1554

merged 1 commit into from
Oct 25, 2024

Conversation

namchuai
Copy link
Collaborator

Describe Your Changes

  • Fix crash dangling reference

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

nguyenhoangthuan99
nguyenhoangthuan99 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@nguyenhoangthuan99 nguyenhoangthuan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namchuai namchuai merged commit 113ea98 into dev Oct 25, 2024
4 checks passed
@namchuai namchuai deleted the j/fix-crash branch October 25, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenhoangthuan99 nguyenhoangthuan99 nguyenhoangthuan99 approved these changes

@vansangpfiev vansangpfiev Awaiting requested review from vansangpfiev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@namchuai @nguyenhoangthuan99