Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor inference service #1536

Merged
merged 5 commits into from
Oct 23, 2024
Merged

chore: refactor inference service #1536

merged 5 commits into from
Oct 23, 2024

Conversation

vansangpfiev
Copy link
Contributor

Describe Your Changes

  • call inference service API instead of http request for start stop model

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review October 22, 2024 10:28
@vansangpfiev vansangpfiev requested a review from namchuai October 22, 2024 10:28
namchuai
namchuai approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ lgtm

@vansangpfiev vansangpfiev merged commit a043b9f into dev Oct 23, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the fix/start-stop branch October 23, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-menlo dan-menlo dan-menlo left review comments

@namchuai namchuai namchuai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vansangpfiev @namchuai @dan-menlo @sangjanai