Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cortex models start has no output if variant not given #1531

Merged
merged 3 commits into from
Oct 22, 2024
Merged

fix: cortex models start has no output if variant not given #1531

merged 3 commits into from
Oct 22, 2024

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Oct 22, 2024 •
edited
Loading

Describe Your Changes

  • better output
  • check for local models if variant is not given

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev requested a review from namchuai October 22, 2024 05:44
namchuai
namchuai approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vansangpfiev vansangpfiev merged commit d449b15 into dev Oct 22, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the fix/models-start branch October 22, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vansangpfiev @namchuai @sangjanai