Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Isolate stdout from the API server and CLI #1526

Merged
merged 2 commits into from
Oct 22, 2024
Merged

fix: Isolate stdout from the API server and CLI #1526

merged 2 commits into from
Oct 22, 2024

Conversation

vansangpfiev
Copy link
Contributor

Describe Your Changes

  • Only print service log if current executable is CLI
  • Use async for engine download API

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review October 21, 2024 09:07
@vansangpfiev vansangpfiev requested a review from namchuai October 21, 2024 09:07
@vansangpfiev vansangpfiev merged commit 3f9680c into dev Oct 22, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the fix/isolate-log-server-cli branch October 22, 2024 01:31
@namchuai namchuai mentioned this pull request Oct 22, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vansangpfiev @namchuai @sangjanai