fix: return model_id instead of error if model is already downloaded #1524

vansangpfiev · 2024-10-21T06:30:46Z

Describe Your Changes

Return model_id instead of error if model is already downloaded

Fixes Issues

bug: uncaught exception of type cpp::bitwizeshift::bad_result_access #1513

Self Checklist

Added relevant comments, esp in complex areas
Updated docs (for bug fixes / features)
Created issues for follow-up changes or refactoring needed

namchuai

✅ lgtm

…caught-exception-1513

fix: print message if model is already downloaded

96dc531

vansangpfiev changed the title ~~fix: rturn model_id instead of error if model is already downloaded~~ fix: return model_id instead of error if model is already downloaded Oct 21, 2024

vansangpfiev marked this pull request as ready for review October 21, 2024 06:33

vansangpfiev requested a review from namchuai October 21, 2024 06:38

namchuai approved these changes Oct 21, 2024

View reviewed changes

sangjanai added 2 commits October 21, 2024 13:45

fix: format

f94c74b

Merge branch 'dev' of https://github.com/janhq/cortex.cpp into fix/un…

0657acf

…caught-exception-1513

vansangpfiev merged commit fcee871 into dev Oct 21, 2024
4 checks passed

vansangpfiev deleted the fix/uncaught-exception-1513 branch October 21, 2024 07:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: return model_id instead of error if model is already downloaded #1524

fix: return model_id instead of error if model is already downloaded #1524

vansangpfiev commented Oct 21, 2024

namchuai left a comment

fix: return model_id instead of error if model is already downloaded #1524

fix: return model_id instead of error if model is already downloaded #1524

Conversation

vansangpfiev commented Oct 21, 2024

Describe Your Changes

Fixes Issues

Self Checklist

namchuai left a comment

Choose a reason for hiding this comment