Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#1425): Streamlining cortex run behavior #1520

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix(#1425): Streamlining cortex run behavior #1520

merged 1 commit into from
Oct 21, 2024

Conversation

namchuai
Copy link
Collaborator

Describe Your Changes

  • Default to attach mode when run cortex run <model_id>
  • Allow run / chain command to run in detach mode cortex run <model_id> -d/--detach

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai merged commit a6b64f8 into dev Oct 21, 2024
4 checks passed
@namchuai namchuai deleted the j/fix-streamlining-cortex-run branch October 21, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vansangpfiev vansangpfiev vansangpfiev approved these changes

@nguyenhoangthuan99 nguyenhoangthuan99 Awaiting requested review from nguyenhoangthuan99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Streamlining cortex run behavior
2 participants
@namchuai @vansangpfiev