Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: binaries for CLI and Server #1499

Merged
merged 54 commits into from
Oct 17, 2024
Merged

fix: binaries for CLI and Server #1499

merged 54 commits into from
Oct 17, 2024

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Oct 16, 2024 •
edited by gabrielle-ong
Loading

Describe Your Changes

  • Create 2 binaries for CLI and Server
  • Move commands into CLI folder
  • Update updater to run installer instead of cortex binary

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

vansangpfiev and others added 30 commits October 14, 2024 15:17
@vansangpfiev
fix: update swagger
5454488
@vansangpfiev
Merge branch 'dev' of github.com:janhq/nitro into fix/swagger
5caa3be
@vansangpfiev
fix: start stop model with API call
3e3dff6
@vansangpfiev
fix: model del
1bd0bbf
@vansangpfiev
fix: model get
536e8ad
@vansangpfiev
fix: model alias
e4a6f7c
@vansangpfiev
fix: model import
30e62fd
@vansangpfiev
fix: model status
0f2e0a4
@vansangpfiev
fix: model list
d37f0bf
@vansangpfiev
fix: models update
2a00d34
@vansangpfiev
fix: engine list
55b5ae2
@vansangpfiev
fix: engine get
963d83f
@vansangpfiev
fix: engine uninstall
ca7b235
@vansangpfiev
Merge branch 'dev' of github.com:janhq/nitro into fix/swagger
6bd9af2
@vansangpfiev
Merge branch 'dev' into fix/swagger
bb2a431
@vansangpfiev
fix: add cmake for cli
0fa1edf
@vansangpfiev
Merge branch 'dev' of github.com:janhq/nitro into fix/swagger
69d0878
@vansangpfiev
Merge branch 'fix/swagger' of github.com:janhq/nitro into fix/swagger
f404b9a
@vansangpfiev
Merge branch 'fix/swagger' into fix/2-b
ab84659
@vansangpfiev
fix: binary name
8eef533
@sangjanai
fix: test CMakeLists
109bf0b
@sangjanai
fix: Makefile
db649e5
@vansangpfiev
Merge branch 'dev' into fix/2-b
3a39b16
@hiento09
fix: installer for 2 binaries
8d437f8
@hiento09
Merge branch 'fix/2-b' of github.com:janhq/cortex.cpp into fix/2-b
ec1131a
@hiento09
fix: installer for 2 binaries
1e64d35
@hiento09
fix: windows installer disable dir page
5a616f7
@vansangpfiev
fix: add upd server cmd (in-progress)
3114515
@hiento09
fix: add installer file to latest folder s3 for nightly updater
120ca7b
@hiento09
fix: installer adds param skip post install
fa5e761
vansangpfiev and others added 14 commits October 17, 2024 08:01
@vansangpfiev vansangpfiev marked this pull request as ready for review October 17, 2024 08:21
@vansangpfiev vansangpfiev merged commit 9f89860 into dev Oct 17, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the fix/2-b branch October 17, 2024 23:28
@hiento09 hiento09 mentioned this pull request Oct 21, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenhoangthuan99 nguyenhoangthuan99 nguyenhoangthuan99 approved these changes

@namchuai namchuai namchuai approved these changes

@hiento09 hiento09 Awaiting requested review from hiento09

@gabrielle-ong gabrielle-ong Awaiting requested review from gabrielle-ong

@dan-menlo dan-menlo Awaiting requested review from dan-menlo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

epic: installer and uninstaller for cortex cli and cortex api binaries epic: Separate CLI and API processes
6 participants
@vansangpfiev @namchuai @nguyenhoangthuan99 @sangjanai @hiento09 @jan-service-account