Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash when calling process kill api #1497

Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix: crash when calling process kill api #1497

merged 1 commit into from
Oct 16, 2024

Conversation

namchuai
Copy link
Collaborator

Describe Your Changes

  • Fix a crash when terminate server when calling processmanager/kill
  • Remove code which manually create DownloadService

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Also remove memory alloc for DownloadService, instead, injected.
@namchuai namchuai marked this pull request as ready for review October 16, 2024 05:09
@namchuai namchuai merged commit 2800e79 into dev Oct 16, 2024
8 checks passed
@namchuai namchuai deleted the j/fix-crash-issue branch October 16, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants