Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: consolidate download service #1365

Merged
merged 3 commits into from
Oct 11, 2024
Merged

chore: consolidate download service #1365

merged 3 commits into from
Oct 11, 2024

Conversation

namchuai
Copy link
Collaborator

@namchuai namchuai commented Sep 30, 2024 •
edited by gabrielle-ong
Loading

Describe Your Changes

  • Consolidate Download service for sending event to client.
  • Clean up warning while building.
  • Adding websocket
  • Adding event queue
  • Update Download service

Screenshots

Download events via websocket
Screenshot 2024-10-03 at 09 10 39

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai force-pushed the j/consolidate-download-service branch 3 times, most recently from b93a501 to 73cf1a3 Compare October 3, 2024 06:28
@namchuai namchuai force-pushed the j/consolidate-download-service branch from ffe22a4 to 69bb241 Compare October 3, 2024 12:00
@namchuai namchuai force-pushed the j/consolidate-download-service branch from 69bb241 to 67f742c Compare October 4, 2024 09:20
@namchuai namchuai force-pushed the j/consolidate-download-service branch from 67f742c to 5595f63 Compare October 11, 2024 14:29
@namchuai namchuai force-pushed the j/consolidate-download-service branch from 5595f63 to a38b56a Compare October 11, 2024 14:36
@namchuai namchuai force-pushed the j/consolidate-download-service branch from a38b56a to fd8b588 Compare October 11, 2024 15:04
@namchuai namchuai marked this pull request as ready for review October 11, 2024 15:04
@namchuai namchuai merged commit 902c6b6 into dev Oct 11, 2024
4 checks passed
@namchuai namchuai deleted the j/consolidate-download-service branch October 11, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vansangpfiev vansangpfiev vansangpfiev approved these changes

@dan-menlo dan-menlo Awaiting requested review from dan-menlo

@nguyenhoangthuan99 nguyenhoangthuan99 Awaiting requested review from nguyenhoangthuan99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@namchuai @vansangpfiev