-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: install local engine #1292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ some small nits. Looks good to me overally!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks @vansangpfiev. A few follow-up questions:
- For
--source
, will it take a folder or a file? - Is it a folder since CUDA dependencies and llamacpp tar.gz are different files?
I will let the engineers scrutinize for code convention.
It is a folder |
Describe Your Changes
Syntax:
-s, --source
: local folder source to install engineThe same logic for CUDA dependencies
Fixes Issues
Self Checklist