Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cli helper #1291

Merged
merged 6 commits into from
Sep 23, 2024
Merged

fix: cli helper #1291

merged 6 commits into from
Sep 23, 2024

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Sep 23, 2024 •
edited
Loading

Describe Your Changes

UI/UX improvement
If a command syntax is incorrect, print useful information for user

Screenshot examples:
image

image

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review September 23, 2024 02:11
namchuai
namchuai approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ lgtm

@vansangpfiev vansangpfiev merged commit eddd0e3 into dev Sep 23, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the fix/cli-helper branch September 23, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenhoangthuan99 nguyenhoangthuan99 nguyenhoangthuan99 approved these changes

@namchuai namchuai namchuai approved these changes

@dan-menlo dan-menlo Awaiting requested review from dan-menlo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vansangpfiev @namchuai @nguyenhoangthuan99