fix: should check model status before start it #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vansangpfiev
requested review from
namchuai,
nguyenhoangthuan99 and
dan-menlo
vansangpfiev
commented
Sep 20, 2024
| @@ -342,20 +342,22 @@ void server::LoadModel(const HttpRequestPtr& req, | |||
| auto func = | |||
| engines_[engine_type].dl->get_function<EngineI*()>("get_engine"); | |||
| engines_[engine_type].engine = func(); | |||
|
|
|||
There was a problem hiding this comment.
Only set logger for engine once, or it will crash if load/unload/load model
namchuai
approved these changes
Sep 20, 2024
nguyenhoangthuan99
approved these changes
Sep 20, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
llamacpp engine does not handle the case when we load a model second time. Should check the model's status before starting it.
Fixes Issues
cortex runflakiness #1272Self Checklist