Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flush chat content to for each response data #1275

Merged
merged 2 commits into from
Sep 20, 2024
Merged

fix: flush chat content to for each response data #1275

merged 2 commits into from
Sep 20, 2024

Conversation

vansangpfiev
Copy link
Contributor

Describe Your Changes

std::cout only flush when buffer is full. Should flush for each message we receive for better UX.

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review September 20, 2024 01:09
namchuai
namchuai approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ lgtm

@vansangpfiev vansangpfiev merged commit c0ce59f into dev Sep 20, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the fix/flush-chat branch September 20, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

@nguyenhoangthuan99 nguyenhoangthuan99 Awaiting requested review from nguyenhoangthuan99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vansangpfiev @namchuai