Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct permissions owner and group #1267

Merged
merged 8 commits into from
Sep 20, 2024
Merged

fix: correct permissions owner and group #1267

merged 8 commits into from
Sep 20, 2024

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Sep 19, 2024 •
edited
Loading

Describe Your Changes

  • The updater works on Windows but not on Linux and macOS due to owner and group. This PR fixes the issue by copying the permissions, owner, and group of the old executable binary.
  • Also add the sudo cortex update message for Linux and macOS.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review September 19, 2024 13:52
@hiento09 hiento09 mentioned this pull request Sep 19, 2024
Closed
dan-menlo
dan-menlo approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@dan-menlo dan-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vansangpfiev Lgtm. Thanks for writing tests.

@vansangpfiev vansangpfiev merged commit ad61259 into dev Sep 20, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the fix/sudo-cmd-upd branch September 20, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-menlo dan-menlo dan-menlo approved these changes

@nguyenhoangthuan99 nguyenhoangthuan99 nguyenhoangthuan99 approved these changes

@namchuai namchuai namchuai approved these changes

@hiento09 hiento09 Awaiting requested review from hiento09

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vansangpfiev @namchuai @nguyenhoangthuan99 @dan-menlo