Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: download pre-release engine #1237

Merged
merged 5 commits into from
Sep 18, 2024
Merged

feat: download pre-release engine #1237

merged 5 commits into from
Sep 18, 2024

Conversation

vansangpfiev
Copy link
Contributor

Describe Your Changes

Syntax:

cortex engines install <engine> -v <version>

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review September 17, 2024 09:25
namchuai
namchuai approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Code looks good to me. Thanks for the test!

@vansangpfiev vansangpfiev merged commit a152a1a into dev Sep 18, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the feat/download-pre-release-engine branch September 18, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

@nguyenhoangthuan99 nguyenhoangthuan99 Awaiting requested review from nguyenhoangthuan99

@dan-menlo dan-menlo Awaiting requested review from dan-menlo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cortex should support pull a pre-release engine
2 participants
@vansangpfiev @namchuai