Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: print all logs to terminal with --verbose #1228

Merged
merged 3 commits into from
Sep 17, 2024
Merged

fix: print all logs to terminal with --verbose #1228

merged 3 commits into from
Sep 17, 2024

Conversation

vansangpfiev
Copy link
Contributor

Describe Your Changes

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review September 16, 2024 07:24
dan-menlo
dan-menlo approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@dan-menlo dan-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@vansangpfiev vansangpfiev merged commit d81c801 into dev Sep 17, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the fix/verbose branch September 17, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-menlo dan-menlo dan-menlo approved these changes

@nguyenhoangthuan99 nguyenhoangthuan99 Awaiting requested review from nguyenhoangthuan99

@namchuai namchuai Awaiting requested review from namchuai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: cortex should output logs to terminal with --verbose
2 participants
@vansangpfiev @dan-menlo