Fix issue postinstaller not run in macos #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiento09
force-pushed
the
fix/postinstaller-macos
branch
from
d2ea3c7 to
02fc3e6
Compare
hiento09
force-pushed
the
fix/postinstaller-macos
branch
from
02fc3e6 to
98af46f
Compare
hiento09
force-pushed
the
fix/postinstaller-macos
branch
from
98af46f to
e6428ff
Compare
hiento09
force-pushed
the
fix/postinstaller-macos
branch
from
e6428ff to
8b2041c
Compare
hiento09
force-pushed
the
fix/postinstaller-macos
branch
2 times, most recently
from
9292d61 to
aaf44ec
Compare
hiento09
force-pushed
the
fix/postinstaller-macos
branch
from
77961c4 to
89ee83d
Compare
hiento09
requested review from
vansangpfiev,
namchuai,
nguyenhoangthuan99 and
dan-menlo
dan-menlo
approved these changes
Sep 16, 2024
vansangpfiev
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Currently, the macOS installer will not trigger the postinstall script because it is just a single pkg file, not a productbuild. This PR aims to fix the issue of the postinstall script not running on macOS by converting it to a productbuild pkg file.
Fixes Issues
Self Checklist