Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: create log folder before logging #1200

Merged
merged 9 commits into from
Sep 13, 2024
Merged

Fix: create log folder before logging #1200

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c53c40f
Fix create log folder before logging
nguyenhoangthuan99 Sep 12, 2024
091c4e4
Fix create log folder before logging
nguyenhoangthuan99 Sep 12, 2024
4786594
Merge branch 'dev' into fix/create-log-folder-if-didn't-existed
nguyenhoangthuan99 Sep 12, 2024
c0495e5
Fix create log folder before logging
nguyenhoangthuan99 Sep 12, 2024
cc181a5
Merge branch 'fix/create-log-folder-if-didn't-existed' of github.com:…
nguyenhoangthuan99 Sep 12, 2024
45565ad
Fix create log folder before logging
nguyenhoangthuan99 Sep 12, 2024
a8859bc
add end to end test for server start
nguyenhoangthuan99 Sep 12, 2024
0af3ac5
add end to end test for log folder created
nguyenhoangthuan99 Sep 12, 2024
d71d791
Update test_create_log_folder.py
nguyenhoangthuan99 Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions engine/main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ void RunServer() {
<< " Port: " << config.apiServerPort << "\n";

// Create logs/ folder and setup log to file
std::filesystem::create_directory(config.logFolderPath);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using std::filesystem::create_directories should be better. Seems like it handle create directory recursively.
https://en.cppreference.com/w/cpp/filesystem/create_directory

Also, I'm worry about concatenate path using / might not work on windows. Should using std::filesystem::path

std::filesystem::create_directory(config.logFolderPath + "/" +
cortex_utils::logs_folder);
trantor::FileLogger asyncFileLogger;
Expand Down Expand Up @@ -160,6 +161,9 @@ int main(int argc, char* argv[]) {
return 0;
} else {
auto config = file_manager_utils::GetCortexConfig();
std::filesystem::create_directory(config.logFolderPath);
std::filesystem::create_directory(config.logFolderPath + "/" +
cortex_utils::logs_folder);
trantor::FileLogger asyncFileLogger;
asyncFileLogger.setFileName(config.logFolderPath + "/" +
cortex_utils::logs_cli_base_name);
Expand Down
Loading