Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cortex models delete command #1189

Merged
merged 7 commits into from
Sep 17, 2024
Merged

feat: cortex models delete command #1189

merged 7 commits into from
Sep 17, 2024

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Sep 11, 2024 •
edited
Loading

Describe Your Changes

Support cortex models delete command
CLI syntax:

cortex models delete <model_id>

Server API:

DELETE http://127.0.0.1:3928/models/model_id

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review September 16, 2024 03:48
@namchuai
Copy link
Collaborator

Would be great if we have some e2e tests 👯

@vansangpfiev
Copy link
Contributor Author

Would be great if we have some e2e tests 👯

Added e2e tests

namchuai
namchuai approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ lgtm

@vansangpfiev vansangpfiev merged commit 554bb84 into dev Sep 17, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the feat/model-delete-cmd branch September 17, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

@nguyenhoangthuan99 nguyenhoangthuan99 Awaiting requested review from nguyenhoangthuan99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: cortex models delete
2 participants
@vansangpfiev @namchuai