-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: nightly updater #1175
feat: nightly updater #1175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ looks good to me! Thank you!
@vansangpfiev Thanks for the Updater PR:
|
As I mentioned above, the logic for variants should be added in CIs, not unit tests |
I see - as long as it's covered, I agree. Lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm - pending Version tests in CI
Describe Your Changes
Support nightly updater. The binary is built with flag
-DCORTEX_VARIANT="nightly"
Syntax
default is the latest nightly
Update logic:
tar
formatcortex
->/temp/cortex_temp
Fixes Issues