Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat Installer and CICD nightly, beta, stable for cortexcpp #1122

Merged
merged 14 commits into from
Sep 11, 2024

Conversation

hiento09
Copy link
Contributor

@hiento09 hiento09 commented Sep 6, 2024

Describe Your Changes

This PR does

  • Add template CICD for compiling cortexcpp on windows, macos and linux
  • Add template installer and uninstaller for cortexcpp
  • Add CICD nightly, beta, stable build channel for cortexcpp

Fixes Issues

You can try our installer at

@hiento09 hiento09 force-pushed the feat/installer-windows branch from f673cab to b246149 Compare September 6, 2024 01:38
@hiento09 hiento09 changed the title Feat installer windows Feat installer and uninstaller for windows, linux, macos Sep 6, 2024
@hiento09 hiento09 force-pushed the feat/installer-windows branch from 58c2862 to 93851e9 Compare September 10, 2024 01:44
@hiento09 hiento09 force-pushed the feat/installer-windows branch from d9646e3 to 67e20a8 Compare September 10, 2024 06:28
@hiento09 hiento09 force-pushed the feat/installer-windows branch 2 times, most recently from c0de7d6 to 2b14638 Compare September 10, 2024 08:36
@hiento09 hiento09 force-pushed the feat/installer-windows branch from 2b14638 to 32c50b7 Compare September 10, 2024 08:56
@hiento09 hiento09 force-pushed the feat/installer-windows branch from 32c50b7 to c2d1c66 Compare September 10, 2024 09:12
@hiento09 hiento09 force-pushed the feat/installer-windows branch 2 times, most recently from d9f63f2 to 2e82710 Compare September 10, 2024 09:34
@hiento09 hiento09 force-pushed the feat/installer-windows branch from dfc11c0 to c0e4191 Compare September 11, 2024 07:33
@hiento09 hiento09 marked this pull request as ready for review September 11, 2024 07:45
@hiento09 hiento09 changed the title Feat installer and uninstaller for windows, linux, macos Feat CICD nightly for cortexcpp Sep 11, 2024
@hiento09 hiento09 force-pushed the feat/installer-windows branch from c0e4191 to c65a648 Compare September 11, 2024 07:54
@hiento09 hiento09 force-pushed the feat/installer-windows branch from c65a648 to 2815191 Compare September 11, 2024 08:12
@hiento09 hiento09 changed the title Feat CICD nightly for cortexcpp Feat CICD nightly, beta, stable for cortexcpp Sep 11, 2024
@hiento09 hiento09 force-pushed the feat/installer-windows branch from a7378fe to ff328ab Compare September 11, 2024 08:36
@hiento09 hiento09 force-pushed the feat/installer-windows branch from ff328ab to c3aaa84 Compare September 11, 2024 08:44
@hiento09 hiento09 force-pushed the feat/installer-windows branch from c3aaa84 to a102fd7 Compare September 11, 2024 09:06
@hiento09 hiento09 force-pushed the feat/installer-windows branch from a102fd7 to 4fdec02 Compare September 11, 2024 09:17
Copy link
Contributor

@dan-menlo dan-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hiento09 I am approving this PR first as I don't want things to block things. I've left a few questions to help my understanding, if you don't mind.

Also, in future, I recommend breaking up a massive PR like this into smaller bite-sized ones:

  • Per-OS PRs (e.g. linux, macos, windows)
  • Helps discoverability, and clearer traceability for engineers

@dan-menlo dan-menlo changed the title Feat CICD nightly, beta, stable for cortexcpp Feat Installer and CICD nightly, beta, stable for cortexcpp Sep 11, 2024
@hiento09 hiento09 merged commit 3c144c1 into dev Sep 11, 2024
8 of 12 checks passed
@hiento09 hiento09 deleted the feat/installer-windows branch September 11, 2024 19:38
@dan-menlo
Copy link
Contributor

@hiento09 FYI, I encountered a bug running cortex-nightly. Will create an issue

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

epic: Stable, Beta and Nightly Builds epic: Cortex.cpp Installer MVP (Local & Network Installer)
3 participants