Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cortex engines uninstall <engine_id> #1088

Closed
2 tasks
Tracked by #1072
namchuai opened this issue Sep 4, 2024 · 5 comments
Closed
2 tasks
Tracked by #1072

feat: cortex engines uninstall <engine_id> #1088

namchuai opened this issue Sep 4, 2024 · 5 comments
Assignees
Labels
category: engine management Related to engine abstraction type: feature request A new feature
Milestone

Comments

@namchuai
Copy link
Collaborator

namchuai commented Sep 4, 2024

Problem
According to https://github.com/janhq/cortex/issues/1072, we should support uninstall engine.

Success Criteria
Working CLI command for cortex engines <engine> uninstall
API for uninstall engine. Not approved yet but I think will be:

  • Method: DELETE
  • engines/<engine>

Additional context
N/A

cc @vansangpfiev @nguyenhoangthuan99 @Van-QA @dan-homebrew

Tasklist

  • Tests
  • Docs
@namchuai namchuai added the type: feature request A new feature label Sep 4, 2024
@namchuai namchuai self-assigned this Sep 4, 2024
@imtuyethan imtuyethan moved this to Scheduled in Menlo Sep 4, 2024
@dan-menlo
Copy link
Contributor

@namchuai @vansangpfiev @SAng

cortex <feature> <command> <subject>
cortex engines uninstall <engine>
cortex engines install <engine>
cortex engines list

We would only move to a cortex engines <engine> <command>, if engines expose their own CLI in the future (imho this is still far away)

cortex engines tensorrt-llm <config>

@namchuai
Copy link
Collaborator Author

namchuai commented Sep 6, 2024

ok, then please let me update accordingly

@freelerobot
Copy link
Contributor

@namchuai can you guys take a look at the syntax discussion in: #1109

We should try to avoid small inconsistencies in syntax. e.g.

# preferred
cortex engines uninstall <engine>

# less preferred
cortex engines <engine> uninstall 

@freelerobot freelerobot changed the title feat: cortex engines <engine> uninstall feat: cortex engines uninstall <engine_id> Sep 6, 2024
@dan-menlo dan-menlo added the category: engine management Related to engine abstraction label Sep 6, 2024
namchuai added a commit that referenced this issue Sep 9, 2024
According to discussion, engine install and uninstall should be:

cortex engines install <engine>
cortex engines uninstall <engine>
@namchuai
Copy link
Collaborator Author

Since the PR is merged, I will move this item to QA.

@freelerobot
Copy link
Contributor

QA'd and closing

@github-project-automation github-project-automation bot moved this from QA to Completed in Menlo Sep 26, 2024
@gabrielle-ong gabrielle-ong added this to the v1.0.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: engine management Related to engine abstraction type: feature request A new feature
Projects
Archived in project
Development

No branches or pull requests

4 participants