-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opam package is broken #1
Comments
It's related to janestreet/ppx_sexp_conv#1. Because ppx_sexp_conv and other deriving plugins depends on ppx_core, ppx_core must have a META that works well with ppx_deriving. That means that ppx_core doesn't behave as a normal library by default... It will be simpler when ppx_deriving uses ocamlfind directly. Currently one workaround is to do this:
However that also means that packages like ppx_sexp_conv will behave as libraries...
|
Couldn't you have two ocamlfind packages, one deriving-like and one library-like ? Also, what do I have to put in my |
I'll try to sort something out for the next release
If you mean "what is the equivalent of
|
Ok, thanks! |
FYI, I forgot to answer but the right line is:
This bug is horrible for newcomers, by the way. If you don't solve it, you should at least document it explicitly. |
The '-predicates' flag is necessary due to the issue here: janestreet-deprecated/ppx_core#1 While the recommended fix is to edit the local _tags file, that introduces a hard dependency on OCaml >= 4.02 due to some changes in the ocamlbuild _tags syntax. To maintain compatibility with older OCaml versions, specify the -predicates build flag as done here.
The '-predicates' flag is necessary due to the issue here: janestreet-deprecated/ppx_core#1 While the recommended fix is to edit the local _tags file, that introduces a hard dependency on OCaml >= 4.02 due to some changes in the ocamlbuild _tags syntax. To maintain compatibility with older OCaml versions, specify the -predicates build flag as done here.
Is the problem still present with the 113.24 release? I changed things so that ppx_deriving plugins depends on |
No comment back from the reporter, so assuming fixed. |
Same deal for compilation, obviously. I don't even understand how your other packages are compiling. :|
The text was updated successfully, but these errors were encountered: