Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Exclude some modules from Modules Dependency Graph #81

Closed
haizerdev opened this issue Dec 8, 2022 · 9 comments
Closed

RF: Exclude some modules from Modules Dependency Graph #81

haizerdev opened this issue Dec 8, 2022 · 9 comments

Comments

@haizerdev
Copy link

image

@janbarari
Copy link
Owner

Hey @haizerdev
Can you give me a detailed brief about this?

Thanks

@janbarari janbarari changed the title Feature: Exclude some modules from Modules Dependency Graph RF: Exclude some modules from Modules Dependency Graph Dec 9, 2022
@haizerdev
Copy link
Author

We found solutions in our particular case, we just have a module for testing other modules like feature_test_app, due to the fact that we always have it locally in the configuration, it gets into local reports, everything is fine. Thanks, i think we can close this feature request)

@janbarari
Copy link
Owner

janbarari commented Dec 15, 2022

Hi @haizerdev
Thank you for reporting this request feature
Actually, I think this is safe and useful to have the exclude modules option inside the plugin configuration. But. I have a question, Would you like to have this only in the graph or all metrics?

Because. there are many metrics that use all module's information, by excluding a bunch of modules, their result becomes invalid.

@janbarari janbarari self-assigned this Dec 15, 2022
@haizerdev
Copy link
Author

I think it will be enough to exclude the module everywhere, and then we can get 2 different graphs for two different configurations in the project (that is, for two different app modules)

@janbarari
Copy link
Owner

Due to misunderstandings among users, The second option is a bit risky to have two different graphs with one configuration.
But the exclude option for everywhere is kind of possible, I need to make sure it won't break the report accuracy.

@ilkupi
Copy link

ilkupi commented Jan 31, 2023

Also I have similar request. In our project we have some test application modules, that are not build during regular CI run, and so Cache Hit Diagrame is kinda useless.
image

@janbarari
Copy link
Owner

Also I have similar request. In our project we have some test application modules, that are not build during regular CI run, and so Cache Hit Diagrame is kinda useless. image

Hmm. Thanks sharing this :)

@janbarari janbarari added this to the 1.0.0-beta8 milestone Feb 5, 2023
@janbarari
Copy link
Owner

janbarari commented Feb 5, 2023

Added in Milestone 1.0.0-beta8
cc: @ilkupi @haizerdev

@janbarari
Copy link
Owner

I have published the latest plugin version 1.0.0-beta8 which includes the feature you reported. Thank you for bringing it to my attention! :)

cc: @ilkupi @haizerdev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants