Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows Terminal Template and Profiles #88

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nalpine
Copy link

@nalpine nalpine commented Oct 24, 2020

I came across Selenized recently and noticed that it didn't have a Windows Terminal profile. I created a template and generated the profiles. I went ahead and ran the tests and the colors appear accurate to my eyes. Not sure if anything more needs to be done so I figured I'd open a pull request.

Dark

image.

Black

image

Light

image

White

image

@czy1996
Copy link

czy1996 commented Dec 6, 2020

Thanks a lot for your work. I'm using your profiles. So far so good.

Solarized schemes appear strangely under Windows Terminal. Your work and Selenized do save my day.

@Ricq
Copy link

Ricq commented Oct 31, 2022

This is very useful. Works as advertised. @jan-warchol can this be merged?

@nachopitt
Copy link

Thanks for contributing and sharing! I also find this really useful! In the meantime I had to checkout the fork/branch and apply the settings manually

Okeanos added a commit to Okeanos/dotfiles-windows that referenced this pull request Sep 10, 2023
Copy link

@Okeanos Okeanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, thanks for providing this.


* Navigate to and open the json file containing the desired Selenized preset.
* Copy the file's text contents to clipboard.
* Open Windows Terminal and navigate to Settings, The Windows Terminal `setings.json` will open in the default editor.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Open Windows Terminal and navigate to Settings, The Windows Terminal `setings.json` will open in the default editor.
* Open Windows Terminal and navigate to Settings, The Windows Terminal `settings.json` will open in the default editor.

@astiob
Copy link

astiob commented Oct 29, 2023

Newer PowerShell automatically colourizes the output of directory listings. By default, it sets subdirectories in “bright white” text on “blue” background, which is illegible in Selenized (both Dark and Light). One way to improve this somewhat is to change the foreground to “black” by adding this to $Profile:

$PSStyle.FileInfo.Directory = "`e[30;44m"

As it happens, this matches the suggested Selenized UNIX dircolors (as far as I can tell).

Then again, this still doesn’t look too good in Selenized Dark, and none of the foreground colours seem very legible on blue background, really.

@darkmattercoder
Copy link

darkmattercoder commented Sep 13, 2024

I have a feeling that the colors are not the best catch here. For instance, look the following output of a pre-commit script:

The white color on the green background looks really ugly.

image

@trallnag
Copy link

trallnag commented Dec 2, 2024

Thanks for sharing, I am satisfied with the light variant. I tweaked it a bit, making the background a bit gray and the white colours darker.

@trallnag
Copy link

trallnag commented Dec 2, 2024

@darkmattercoder, in the light variant it is fine

grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants