devonfw#440: fixed tests for linux and windows

removed thrown exception from makeExecutable
jan-vcapgemini · Sep 5, 2024 · d2cc46c · d2cc46c
1 parent 4e2f009
commit d2cc46c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/cli/src/main/java/com/devonfw/tools/ide/io/FileAccess.java b/cli/src/main/java/com/devonfw/tools/ide/io/FileAccess.java
@@ -1,6 +1,5 @@
 package com.devonfw.tools.ide.io;
 
-import java.io.IOException;
 import java.nio.file.Path;
 import java.nio.file.attribute.PosixFilePermission;
 import java.util.List;
@@ -247,7 +246,6 @@ default void extract(Path archiveFile, Path targetDir, Consumer<Path> postExtrac
    * Makes a file executable. Equivalent of using 'chmod a+x'. Adds execute permissions to current file permissions.
    *
    * @param filePath Path to the file.
-   * @throws IOException if an I/O error occurs.
    */
-  void makeExecutable(Path filePath) throws IOException;
+  void makeExecutable(Path filePath);
 }
diff --git a/cli/src/main/java/com/devonfw/tools/ide/io/FileAccessImpl.java b/cli/src/main/java/com/devonfw/tools/ide/io/FileAccessImpl.java
@@ -840,7 +840,7 @@ public boolean isEmptyDir(Path dir) {
   }
 
   @Override
-  public void makeExecutable(Path filePath) throws IOException {
+  public void makeExecutable(Path filePath) {
     if (SystemInfoImpl.INSTANCE.isWindows()) {
       return;
     }

diff --git a/cli/src/main/java/com/devonfw/tools/ide/tool/intellij/Intellij.java b/cli/src/main/java/com/devonfw/tools/ide/tool/intellij/Intellij.java
@@ -73,6 +73,7 @@ private void createStartupCommandScript() {
         bashFile = Files.createFile(getToolBinPath().resolve(getName()));
         MacOsHelper macOsHelper = new MacOsHelper(context);
         Path appPath = macOsHelper.findAppDir(macOsHelper.findRootToolPath(this, context));
+        this.context.getFileAccess().makeExecutable(getToolPath().resolve(appPath).resolve(IdeContext.FOLDER_CONTENTS).resolve("MacOS").resolve(IDEA));
         Files.writeString(bashFile,
             bashFileContentStart + getToolPath().resolve(appPath).resolve(IdeContext.FOLDER_CONTENTS).resolve("MacOS").resolve(IDEA) + bashFileContentEnd);
       } catch (IOException e) {
@@ -81,6 +82,7 @@ private void createStartupCommandScript() {
     } else if (this.context.getSystemInfo().isWindows()) {
       try {
         bashFile = Files.createFile(getToolBinPath().resolve(getName()));
+        this.context.getFileAccess().makeExecutable(getToolBinPath().resolve(IDEA64_EXE));
         Files.writeString(bashFile,
             bashFileContentStart + getToolBinPath().resolve(IDEA64_EXE) + bashFileContentEnd);
       } catch (IOException e) {
@@ -89,18 +91,15 @@ private void createStartupCommandScript() {
     } else {
       try {
         bashFile = Files.createFile(getToolBinPath().resolve(getName()));
+        this.context.getFileAccess().makeExecutable(getToolBinPath().resolve(IDEA_BASH_SCRIPT));
         Files.writeString(bashFile,
             bashFileContentStart + getToolBinPath().resolve(IDEA_BASH_SCRIPT) + bashFileContentEnd);
       } catch (IOException e) {
         throw new RuntimeException(e);
       }
     }
 
-    try {
-      context.getFileAccess().makeExecutable(bashFile);
-    } catch (IOException e) {
-      throw new RuntimeException(e);
-    }
+    context.getFileAccess().makeExecutable(bashFile);
   }
 
 }