Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed lrelease and .qm files check-in from release process. #996

Merged

Conversation

softins
Copy link
Member

@softins softins commented Jul 23, 2024

Short description of changes

Removed lrelease and .qm files check-in from release process. These steps no longer needed as .qm files are now compiled on the fly.

Context: Fixes an issue? Related issues

This update is needed due to the PR jamulussoftware/jamulus#3288

Status of this Pull Request

Ready

What is missing until this pull request can be merged?

Nothing

Does this need translation?
NO

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I'm sure that this Pull Request goes to the correct branch

These steps no longer needed as .qm files are now compiled on the fly.
@pljones pljones added this to the Release 3.11.0 milestone Jul 23, 2024
@pljones pljones added the translation Issue or PR releated to translation label Jul 23, 2024
@ignotus666
Copy link
Contributor

@softins @pljones this stuff doesn't get translated.

@softins
Copy link
Member Author

softins commented Jul 23, 2024

@softins @pljones this stuff doesn't get translated.

Ok, that's cool, I wasn't sure, having not made website changes before.

@softins softins merged commit a419206 into jamulussoftware:next-release Jul 23, 2024
1 check passed
@softins softins deleted the obsoleted-lrelease-and-qm branch July 23, 2024 21:33
@pljones pljones removed the translation Issue or PR releated to translation label Jul 24, 2024
@pljones
Copy link
Contributor

pljones commented Jul 24, 2024

@softins @pljones this stuff doesn't get translated.

The url contains contribute/en -- should it be outside the language-specified tree?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants