Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connect to server help message #983

Merged
merged 3 commits into from
Feb 18, 2021

Conversation

ann0see
Copy link
Member

@ann0see ann0see commented Feb 12, 2021

Might solve #847

Todo: Wording of the sentence, translation (but that's something for the next release).

Maybe we could use: Setup your audio, connect and start jamming!

Not Connected to a server:

ConnectServer

Connected:
Connected

@ann0see ann0see marked this pull request as ready for review February 12, 2021 21:06
@ann0see
Copy link
Member Author

ann0see commented Feb 12, 2021

@dcorson-ticino-com I think this would be a "quick" fix for your feature request. I've now also added the "gray out input levels if not connected" feature. Probably a re-arrangement of the UI would be good, but I think your ideas are far from finished now. Also I'd personally like to have incremental changes with this and #973 being small ones.

@pljones
Copy link
Collaborator

pljones commented Feb 13, 2021

"Setup" should be two words.
"Set up your audio" only happens once, so shouldn't be a "nag" like this - first time installation hand-holding only.

I'd also prefer it as replacing "Server" in the group box title, rather than as a separate label like you've shown.

@ann0see
Copy link
Member Author

ann0see commented Feb 13, 2021

I'd also prefer it as replacing "Server" in the group box title, rather than as a separate label like you've shown.

The problem with this would be that it's probably a lot less visible.

"Setup" should be two words.

Ok. Can you change it? I'll need some time on other things now.

"Set up your audio" only happens once, so shouldn't be a "nag" like this - first time installation hand-holding only.

Agree. But how should we detect a first time user? By checking if the profile name is "No Name"?

Set up your audio could also mean "connect your instrument" which you'd need to do before starting every time you use Jamulus.

@pljones
Copy link
Collaborator

pljones commented Feb 13, 2021

The first time user process shouldn't be part of Jamulus at all. It's only needed once.

@dcorson-ticino-com
Copy link
Contributor

To reduce the nagging a bit I would make the message only shown at program start-up before the first connection.
I agree that the audio setup should only be at installation time. Would a bool in the ini file be an adequate way of seeing this?
D

@gene96817
Copy link

Sometimes another application might make changes to the underlying system that affects Jamulus. Will there be an easy way to repeat the first time set up? This is also useful for a new user that didn't get the right results in their first connection. Then we/I need to handhold them through the first time set up (again) to get the process right.

@ann0see
Copy link
Member Author

ann0see commented Feb 13, 2021

@gene96817 unfortunately the first time setup doesn't exist yet. Can you open an issue and describe what you'd like? We can then discuss everything there.

@ann0see
Copy link
Member Author

ann0see commented Feb 16, 2021

Just changed Setup to Set up. Any chance this will be part of the next release?

@ann0see
Copy link
Member Author

ann0see commented Feb 17, 2021

@pljones I hope you know that this will also gray out the level meter if you're not connected.

@pljones
Copy link
Collaborator

pljones commented Feb 17, 2021

Yes, I saw that. I think it makes sense. When Jamulus isn't connect to a server, it should have the sound card closed. (On Windows, it doesn't have the ASIO driver open when it's not connected to the server. It should not connect to JACK except when connected to a server, either, to avoid putting load on the system unnecessarily - I consider current behaviour ... unhelpful. No idea on MacOS.)

@ann0see
Copy link
Member Author

ann0see commented Feb 17, 2021

I consider current behaviour ... unhelpful

That makes two of us. Probably a larger todo for the next release.

What I would suggest:

If ASIO/Jack/... wasn't found or doesn't work (wrong sample rate,...): open Jamulus but give a clear warning what is wrong. Add a button which opens settings,... Do you want to open a new issue on this?

@ann0see ann0see requested review from softins and gilgongo and removed request for dcorson-ticino-com February 17, 2021 18:47
@atsampson
Copy link
Contributor

It should not connect to JACK except when connected to a server, either, to avoid putting load on the system unnecessarily

I'm not sure this is a huge worry - Jamulus doesn't do very much in its JACK callbacks when it's not connected to a server, so the additional load from this is pretty minimal. From a very rough measurement on my machine, jackd takes 0.7% CPU when nothing's connected, and Jamulus takes 0.3% when idling. For people like me who have Jamulus connected to non-default JACK ports, you'd also need some external mechanism for remaking your connections every time you connect to a server, which would be possible but a bit more work.

@gene96817
Copy link

(I don't have a Windows machine so I can't reconfirm this behavior.)
It seems the Windows machines can only have one application access the microphone. This means it matters if Jamulus is open before Zoom or visa versa. If the closes its connection to the sound card, does this mean Jamulus might not be able to get a connection (because another application has taken control)? This is not an issue on Macs.

@ann0see
Copy link
Member Author

ann0see commented Feb 17, 2021

Did you try ASIO4ALL v2.13 or have a person who can verify if this solved this behaviour? For me, I think v2.13 partly "fixed" this error

@ann0see ann0see merged commit 18e931e into jamulussoftware:master Feb 18, 2021
@ann0see ann0see deleted the ConnectServerMessage branch February 18, 2021 08:42
@pljones
Copy link
Collaborator

pljones commented Feb 18, 2021

It seems the Windows machines can only have one application access the microphone.

This is completely dependent on the driver in use.

@gene96817
Copy link

All those "dependent on" makes it so hard to give assistance. :(

@pljones pljones added this to the Release 3.7.0 milestone Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

When not connected: "Please connect to a server to hear yourself and others"
6 participants