-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add connect to server help message #983
Conversation
@dcorson-ticino-com I think this would be a "quick" fix for your feature request. I've now also added the "gray out input levels if not connected" feature. Probably a re-arrangement of the UI would be good, but I think your ideas are far from finished now. Also I'd personally like to have incremental changes with this and #973 being small ones. |
"Setup" should be two words. I'd also prefer it as replacing "Server" in the group box title, rather than as a separate label like you've shown. |
The problem with this would be that it's probably a lot less visible.
Ok. Can you change it? I'll need some time on other things now.
Agree. But how should we detect a first time user? By checking if the profile name is "No Name"? Set up your audio could also mean "connect your instrument" which you'd need to do before starting every time you use Jamulus. |
The first time user process shouldn't be part of Jamulus at all. It's only needed once. |
To reduce the nagging a bit I would make the message only shown at program start-up before the first connection. |
Sometimes another application might make changes to the underlying system that affects Jamulus. Will there be an easy way to repeat the first time set up? This is also useful for a new user that didn't get the right results in their first connection. Then we/I need to handhold them through the first time set up (again) to get the process right. |
@gene96817 unfortunately the first time setup doesn't exist yet. Can you open an issue and describe what you'd like? We can then discuss everything there. |
Just changed Setup to Set up. Any chance this will be part of the next release? |
@pljones I hope you know that this will also gray out the level meter if you're not connected. |
Yes, I saw that. I think it makes sense. When Jamulus isn't connect to a server, it should have the sound card closed. (On Windows, it doesn't have the ASIO driver open when it's not connected to the server. It should not connect to JACK except when connected to a server, either, to avoid putting load on the system unnecessarily - I consider current behaviour ... unhelpful. No idea on MacOS.) |
That makes two of us. Probably a larger todo for the next release. What I would suggest: If ASIO/Jack/... wasn't found or doesn't work (wrong sample rate,...): open Jamulus but give a clear warning what is wrong. Add a button which opens settings,... Do you want to open a new issue on this? |
I'm not sure this is a huge worry - Jamulus doesn't do very much in its JACK callbacks when it's not connected to a server, so the additional load from this is pretty minimal. From a very rough measurement on my machine, jackd takes 0.7% CPU when nothing's connected, and Jamulus takes 0.3% when idling. For people like me who have Jamulus connected to non-default JACK ports, you'd also need some external mechanism for remaking your connections every time you connect to a server, which would be possible but a bit more work. |
(I don't have a Windows machine so I can't reconfirm this behavior.) |
Did you try ASIO4ALL v2.13 or have a person who can verify if this solved this behaviour? For me, I think v2.13 partly "fixed" this error |
This is completely dependent on the driver in use. |
All those "dependent on" makes it so hard to give assistance. :( |
Might solve #847
Todo: Wording of the sentence, translation (but that's something for the next release).
Maybe we could use: Setup your audio, connect and start jamming!
Not Connected to a server:
Connected:
