Move driver setup button under driver selection #976 #977

ann0see · 2021-02-10T18:54:10Z

Solves #973

~~The tooltip of this still tells you about the buffer settings. I'm not sure how to change that.~~ Done

Solves #973

pljones · 2021-02-10T19:33:07Z

How to find out:

peter@fs-peter:~/git/Jamulus-wip$ grep -nr butDriverSetup src
src/clientsettingsdlgbase.ui:245:          <widget class="QPushButton" name="butDriverSetup">
src/clientsettingsdlgbase.ui:677:  <tabstop>butDriverSetup</tabstop>
src/clientsettingsdlg.cpp:185:    butDriverSetup->setWhatsThis ( strSndCrdBufDelay );
src/clientsettingsdlg.cpp:186:    butDriverSetup->setAccessibleName ( tr ( "ASIO setup push button" ) );
src/clientsettingsdlg.cpp:187:    butDriverSetup->setToolTip ( strSndCrdBufDelayTT );
src/clientsettingsdlg.cpp:281:    butDriverSetup->setText ( tr ( "ASIO Setup" ) );
src/clientsettingsdlg.cpp:284:    butDriverSetup->hide();
src/clientsettingsdlg.cpp:418:    QObject::connect ( butDriverSetup, &QPushButton::clicked,

So 185, 186, 187.

ann0see · 2021-02-10T20:44:04Z

Ok. Thanks! Now the question is: What should the text be?

My first thought:


    // Driver setup button
    QString strSndCardDriverSetup = "<b>" tr ( "Sound card driver settings" ) + "</b>" +
        tr ( "The sound card driver settings button opens the driver settings pannel of " +
        "your sound card. Some drivers allow you to change buffer settings, others like the " +
        "ASIO4ALL let you choose input or outputs of your device(s). To show the inputs or outputs " +
        "in ASIO4ALL, click on the tool icon (= advanced view) on the bottom right, " +
        "click the plus icon left to the sound card and afterwards enable the correct input and output. " +
        "By hovering over an input output under a soundcard, you can see if it is an input or output. " +
        "Make sure to only enable devices which support a sample rate of " ) + SYSTEM_SAMPLE_RATE_HZ +
        tr ( "Hz. To check this in ASIO4ALL, hover over the device or input/output and check the " +
        "supported sample rate. New devices will not automatically be added to ASIO4ALL. Therefore, " +
        "please restart " ) + APP_NAME + tr ( " if you connect new devices." );

    QString strSndCardDriverSetupTT = tr ( "Opens the driver settings. Note: " + APP_NAME + " currently " +
        "only supports devices supporting a sample rate of " + SYSTEM_SAMPLE_RATE_HZ "Hz. " +
        "You will not be able to select a driver/device which doesn't. " +
        "If you use ASIO4ALL, you might need to choose the correct input output devices which also support " +
        "this sample rate. Check this by hovering over a device. Selecting devices " +
        "in ASIO4ALL can be done by clicking here, afterwards in ASIO4ALL clicking on the tool icon "
        "(advanced view), then on the plus icon left to the sound card. Now select the correct input or output "
        "devices. For more help see the Website." ) + TOOLTIP_COM_END_TEXT;

pljones · 2021-02-10T21:58:04Z

I would not add anything specific to any driver. Reference the web site for more guidance on setting up your sound card but nothing deeper than that.

ann0see · 2021-02-10T21:59:30Z

Ok. So I'd be happy about a suggestion from you and @gilgongo

ann0see · 2021-02-12T19:19:38Z

What about:


    // Driver setup button
    QString strSndCardDriverSetup = "<b>" tr ( "Sound card driver settings" ) + "</b>" +
        tr ( "The sound card driver settings button opens the driver settings pannel of " +
        "your sound card. Some drivers allow you to change buffer settings, others like the " +
        "ASIO4ALL let you choose input or outputs of your device(s)." );

    QString strSndCardDriverSetupTT = tr ( "Opens the driver settings. Note: " + APP_NAME + " currently " +
        "only supports devices supporting a sample rate of " + SYSTEM_SAMPLE_RATE_HZ "Hz. " +
        "You will not be able to select a driver/device which doesn't. " +
        "For more help see the Website." ) + TOOLTIP_COM_END_TEXT;

pljones · 2021-02-12T19:42:26Z

I've not thought of anything better myself. I'd still be inclined to say less, though, on strSndCardDriverSetup -- maybe completely lose the last sentence? It should just say it gets you to the sound card settings - I feel saying more is making it sound like it's somehow something Jamulus controls.

ann0see · 2021-02-12T19:50:12Z

Sure, It can be removed. I might need to add my explanation to this:

My intention behind adding ASIO4ALL was to help new users (who probably use ASIO4ALL and will therefore click this button and open this help text), should at least receive some help here. That's why I initially wrote about this information. We might need to think a bit more of ASIO4ALL first user problems. That's probably a topic for another issue.

pljones · 2021-02-12T19:51:51Z

Yep, I understand the intent - but for non-ASIO4ALL users, it could be off-putting / misleading. I think things like this are better handled in "first time user" hand-holding.

ann0see · 2021-02-12T19:59:58Z

I think things like this are better handled in "first time user" hand-holding.

... which doesn't exist yet ;-). But of course, this is another issue.

Ok. So maybe your suggestion should be applied then? Any other thoughts?

gene96817 · 2021-02-13T00:42:10Z

I appreciate the level of attention and effort for addressing issues with AISO4ALL.

MacOS users need to be assured they do not have similar or related problems.

With all the discussion about AISO4ALL, how should Windows users think about manufacture specific AISO drivers. The current documentation suggest they use the AISO4ALL driver. I have seen the Dell AISO driver perform better. Could a user see more than three ASIO drivers installed in their machine?

ann0see · 2021-02-13T06:14:51Z

I have seen the Dell AISO driver perform better.

Just a short question: is it a generic driver too?

Could a user see more than three ASIO drivers installed in their machine?

Yes. I don't know why they shouldn't.

gene96817 · 2021-02-13T08:04:33Z

The Dell ASIO appears to only know about the built-in audio circuit.

ann0see · 2021-02-13T08:08:02Z

Ok. Can you link it? I'd like to test it on my HP PC. Maybe it's compatible?

hoffie · 2021-02-13T08:11:28Z

Ok. Can you link it? I'd like to test it on my HP PC. Maybe it's compatible?

Just found this: https://www.dell.com/support/driver/de/de/debsdt1/driversdetails?driverid=7776f

There are also attempts at getting similar things running by editing INF files:
https://www.tenforums.com/sound-audio/150202-realtek-asio-driver-installs-but-fails-operate.html

I have no experience with this. Maybe it'll work better. Doesn't sound easier to set up than ASIO4ALL at the first glance though.

pljones · 2021-02-13T09:30:24Z

Could a user see more than three ASIO drivers installed in their machine?

Yep - I've got six on one of my two machines (not the one I actually use for jamming, either!).

ann0see · 2021-02-14T11:00:21Z

Note to self: syntax error.

Still to be tested.

Sorry for the force pushes. I shouldn't work on the main repo.

ann0see · 2021-02-14T15:40:28Z

Ok. Ready for review.
I'd especially like to have a feedback on the description here from @gilgongo

@pljones
Should this be part of the next release or should we still wait? I'm a bit afraid that existing users might be confused with the change here. New users in contrary would probably find and understand the new position faster.

pljones · 2021-02-14T19:12:21Z

I think most users won't notice the difference, to be honest. If their settings are working, they won't be looking at the ASIO and audio buffer bits. I think it's pretty safe to merge.

pljones · 2021-02-14T19:21:12Z

Can you confirm that you have tested this on Linux with JACK and that the hover text and What's This still make sense there?

ann0see · 2021-02-14T19:22:12Z

This doesn't even show up on Linux. I will re-test it.

ann0see · 2021-02-14T19:26:53Z

Debian 10:

This doesn't even show up.

There are still some things up in #977 but they can also be included in another PR.

gilgongo · 2021-02-14T19:38:45Z

Would it be better to use "this" to refer to the element the user is looking at? Maybe also remove the redundant "panel". Shorter at least:

"This opens the driver settings of your sound card. Some drivers allow you to change buffer settings, others like the ASIO4ALL let you choose input or outputs of your device(s)"

ann0see · 2021-02-14T19:51:12Z

@gilgongo now I use your suggestion.

Settings UI changes for ASIO

ann0see

@pljones @mulyaj added a few suggestions here.

ann0see · 2021-02-14T20:22:00Z

src/clientsettingsdlgbase.ui

@@ -674,7 +675,6 @@
  <tabstop>rbtBufferDelayPreferred</tabstop>
  <tabstop>rbtBufferDelayDefault</tabstop>
  <tabstop>rbtBufferDelaySafe</tabstop>
-  <tabstop>butDriverSetup</tabstop>


@mulyaj I think we need to re-add this. So you'd add

<tabstop>cbxSoundcard</tabstop> <tabstop>butDriverSetup</tabstop>

right under <tabstops> . I will test if this works.

In fact, it seems to work without this too. Nevertheless, I will do some more tests.

Please keep them. They help accessibility tools, as far as I'm aware.

I'm also quite sure that they should stay. @mulyaj or me can add them (but I'll not do it before tomorrow)

I'll add them back

src/clientsettingsdlg.cpp

Added back tabstops, created name for device groupbox

ann0see · 2021-02-15T09:34:47Z

Ok. It doesn't seem to change anything. But that's ok I think. So from my point of view, this is ready to be merged now.

Move ASIO setup under driver selection

eb2c6d2

Solves #973

ann0see linked an issue Feb 10, 2021 that may be closed by this pull request

Move ASIO-Setup button above Driver selection #973

Closed

ann0see self-assigned this Feb 13, 2021

ann0see force-pushed the MoveASIO branch from 08d3de2 to a30242d Compare February 14, 2021 11:28

Add help text to sound card button

dc3100c

ann0see force-pushed the MoveASIO branch from e73e389 to dc3100c Compare February 14, 2021 15:08

Keep in sync with other explanations

9eb6072

Simplify driver button explanation

03e58c8

mulyaj and others added 2 commits February 14, 2021 21:04

Settings UI changes for ASIO

1287d96

Merge pull request #1000 from ann0see/mulyaj_ASIOUI

aaf1d97

Settings UI changes for ASIO

ann0see commented Feb 14, 2021

View reviewed changes

mulyaj reviewed Feb 14, 2021

View reviewed changes

src/clientsettingsdlg.cpp Outdated Show resolved Hide resolved

Rename ASIO Setup to ASIO Device Settings

9069aa1

ann0see force-pushed the MoveASIO branch from c351325 to 9069aa1 Compare February 14, 2021 20:44

ann0see requested a review from mulyaj February 14, 2021 20:48

added back tabstops, created name for device groupbox

562672b

mulyaj mentioned this pull request Feb 14, 2021

Added back tabstops, created name for device groupbox #1002

Merged

ann0see added 2 commits February 15, 2021 10:08

Move tabstop

a04e537

Merge pull request #1002 from mulyaj/ASIO_edit

5ed8752

Added back tabstops, created name for device groupbox

ann0see requested a review from pljones February 15, 2021 09:34

gilgongo approved these changes Feb 15, 2021

View reviewed changes

pljones approved these changes Feb 15, 2021

View reviewed changes

pljones merged commit b59fad7 into master Feb 15, 2021

ann0see deleted the MoveASIO branch February 15, 2021 20:53

ann0see added a commit that referenced this pull request Feb 15, 2021

Add #977

110da30

pljones added this to the Release 3.7.0 milestone Nov 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move driver setup button under driver selection #976 #977

Move driver setup button under driver selection #976 #977

ann0see commented Feb 10, 2021 •

edited

Loading

pljones commented Feb 10, 2021

ann0see commented Feb 10, 2021

pljones commented Feb 10, 2021

ann0see commented Feb 10, 2021

ann0see commented Feb 12, 2021

pljones commented Feb 12, 2021

ann0see commented Feb 12, 2021

pljones commented Feb 12, 2021

ann0see commented Feb 12, 2021

gene96817 commented Feb 13, 2021

ann0see commented Feb 13, 2021

gene96817 commented Feb 13, 2021

ann0see commented Feb 13, 2021

hoffie commented Feb 13, 2021

pljones commented Feb 13, 2021 •

edited

Loading

ann0see commented Feb 14, 2021 •

edited

Loading

ann0see commented Feb 14, 2021

pljones commented Feb 14, 2021

pljones commented Feb 14, 2021

ann0see commented Feb 14, 2021

ann0see commented Feb 14, 2021 •

edited

Loading

gilgongo commented Feb 14, 2021

ann0see commented Feb 14, 2021

ann0see left a comment

ann0see Feb 14, 2021 •

edited

Loading

ann0see Feb 14, 2021

pljones Feb 14, 2021

ann0see Feb 14, 2021

mulyaj Feb 14, 2021

ann0see commented Feb 15, 2021

Move driver setup button under driver selection #976 #977

Move driver setup button under driver selection #976 #977

Conversation

ann0see commented Feb 10, 2021 • edited Loading

pljones commented Feb 10, 2021

ann0see commented Feb 10, 2021

pljones commented Feb 10, 2021

ann0see commented Feb 10, 2021

ann0see commented Feb 12, 2021

pljones commented Feb 12, 2021

ann0see commented Feb 12, 2021

pljones commented Feb 12, 2021

ann0see commented Feb 12, 2021

gene96817 commented Feb 13, 2021

ann0see commented Feb 13, 2021

gene96817 commented Feb 13, 2021

ann0see commented Feb 13, 2021

hoffie commented Feb 13, 2021

pljones commented Feb 13, 2021 • edited Loading

ann0see commented Feb 14, 2021 • edited Loading

ann0see commented Feb 14, 2021

pljones commented Feb 14, 2021

pljones commented Feb 14, 2021

ann0see commented Feb 14, 2021

ann0see commented Feb 14, 2021 • edited Loading

gilgongo commented Feb 14, 2021

ann0see commented Feb 14, 2021

ann0see left a comment

Choose a reason for hiding this comment

ann0see Feb 14, 2021 • edited Loading

Choose a reason for hiding this comment

ann0see Feb 14, 2021

Choose a reason for hiding this comment

pljones Feb 14, 2021

Choose a reason for hiding this comment

ann0see Feb 14, 2021

Choose a reason for hiding this comment

mulyaj Feb 14, 2021

Choose a reason for hiding this comment

ann0see commented Feb 15, 2021

ann0see commented Feb 10, 2021 •

edited

Loading

pljones commented Feb 13, 2021 •

edited

Loading

ann0see commented Feb 14, 2021 •

edited

Loading

ann0see commented Feb 14, 2021 •

edited

Loading

ann0see Feb 14, 2021 •

edited

Loading