Automated build for Android APK (updated) #880

nefarius2001 · 2021-01-23T12:33:16Z

Credit and thanks to @ann0see for contributing & support

Resolves #835 Automated build for Android APK

open/related issues, that I see as upcomming improvements, but not part of this PR/issue:
#856 harmonized folders
#857 multiple APK-platforms

this PR creates automatically:

a prerelease for all tags that start with "r" and contain "beta"
a release for all tags that start with "r"
I ask you to accept the PR with this minimal behaviour and lets continue the discussion about behaviour in Automated github builds #854

The build process for android can be improved still, but I think it is already very good to have a working state as basis.

this replaces #878

Co-Authored-By: nefarius2001 <[email protected]>

Co-Authored-By: ranfdev <[email protected]>

This reverts commit b6feab3. keeps additional mirror parameter as comment

…only if desired

ann0see · 2021-01-23T15:52:29Z

@nefarius2001 see my comments from the last PR

.github/workflows/autobuild.yml

…atpack-upload)

corrados · 2021-01-24T08:15:03Z

Is this ready to be merged now?

ann0see

Probably soon. Just need to clarify a few things (see review.)

Note to corrados: as far as I understand, with these changes the latest tag is no longer automatically moved.

Jamulus.pro

android/automated_build/install-qt.sh

nefarius2001 · 2021-01-24T11:04:03Z

Is this ready to be merged now?

#883 needs to be resolved as a part of this.

…roid_build_dev

ann0see · 2021-01-27T17:25:29Z

I will re-check if everything works. Afterwards, I think, this can be merged @nefarius2001 ?

pljones · 2021-01-27T17:43:09Z

I will re-check if everything works. Afterwards, I think, this can be merged @nefarius2001 ?

Did anyone confirm if Code QL scans can or cannot be done on the Android build?

Also, @ann0see, it says you've got "Changes requested". Have they been made?

ann0see · 2021-01-27T17:46:50Z

I didn't. I'm currently simulating a few things on my repo and have found a few "issues":

If the latest tag is pushed, currently nothing happens (we have to add the "latest" tag to the .yml file)
The Changelog detection is broken since the changelog still contains *git not *dev
Currently checking: What does the latest release output? It's currently just labelled as pre-release which is not what I think it should be labelled.
The flatpak is not named after the version of Jamulus (But I couldn't get it to run on my debian 10 machine)

For my proposed changes, see all differences until ann0see@66e0b6e

ann0see · 2021-01-27T17:56:55Z

.github/actions_scripts/analyse_git_reference.py

+
+
+    if pushed_name == "latest":
+        print('this reference is a Latest-Tag')


Why is the latest release a prerelease?

I didnt care there, I thought the idea of this tag had died.

GitHub has a „latest release“ feature anyway.

I’d there an URL which is always accessible and pointing to the latest release? I think @corrados said somewhere that probably many people use this somehow. I also think that a url which always points to the latest release is needed.

look at this:
https://github.com/nefarius2001/jamulus/releases/latest

It points to the release with the youngest creation time, and is not related to the "latest" tag. I'd prefer that, since then the files also keep their version in name. But whoever actually does the releases, has the last word on how they should be done.

Ok. I didn't know about this feature.

since then the files also keep their version in name

I would like to have a steady link which we could link on the jamulus.io page as (second) mirror.
The user would then click on "Download Jamulus" and the download would then start right away without leaving jamulus.io

This would provide a better user experience since they wouldn't be redirected to sourceforge which some people dislike (there are issues on that here).

The binaries would still be uploaded to SourceForge and maybe even linked on jamulus.io so that we have multiple mirrors. Multiple mirrors provide redundancy and also higher availability. If one is down, there is still the other one.

Jamulus.pro

ann0see · 2021-01-27T18:01:24Z

it says you've got "Changes requested". Have they been made?

I requested changes: #880 (comment)

#880 (comment)

etc. So it's not yet ready to be merged. They must be discussed before a merge.

ann0see · 2021-01-27T18:09:35Z

Did anyone confirm if Code QL scans can or cannot be done on the Android build?

@nefarius2001 is/was working on something (according to GH Actions on his repo), but IDK if that's related to CodeQl.

ann0see · 2021-01-27T18:12:47Z

.github/workflows/autobuild.yml

-      - "r*" # run this action if a tag beginning with r is created
-  workflow_dispatch:
-
+      - "r*"


Suggested change

- "r*"

- "r*"

- "latest"

added latest as trigger
decide yourself if you want to use the "latest" tag or leave that code unused/triggered

nefarius2001 · 2021-01-27T21:14:28Z

Hi,
sorry for the late reply.

I am still working on the overall build, packing CodeQL and artifacts in one job. ( #854 and #856 )
Do you prefer to that as a separate PR then, or pe a part of "this"?
Checking CodeQL for Android is still on my list for later :)

pljones · 2021-01-27T22:35:56Z

Checking CodeQL for Android is still on my list for later :)

Best to raise the issue for tracking it :)

nefarius2001 · 2021-01-28T00:11:00Z

changelog was not working, fix in progress

so status is: not ready :(

nefarius2001 · 2021-01-28T22:35:54Z

looks good to me
https://github.com/nefarius2001/jamulus/releases/tag/r_test
https://github.com/nefarius2001/jamulus/releases/tag/r_test_beta

ready to merge from my side

Resolves:
#835 Automated build for Android APK

still in progress, but independent:
#856 harmonized folders

one job for artifacts & codeql

corrados · 2021-01-29T06:14:38Z

@ann0see Are you fine with merging it now?

ann0see

Yes.

ann0see and others added 12 commits January 21, 2021 22:03

Use approved verbs

64e2824

Add Android build by @nefarius2001

3e0c0e7

Co-Authored-By: nefarius2001 <[email protected]>

Move flatpak to autobuild

4b7b38c

Co-Authored-By: ranfdev <[email protected]>

Fix non working Qt mirror

b6feab3

enable building & release for all branches

7a39f89

change branch name in flatpack manifest

aa12198

fix

79cf6b1

cleanup comments & console

6f741fb

Revert "Fix non working Qt mirror"

aee3013

This reverts commit b6feab3. keeps additional mirror parameter as comment

cleaner release-tags, remove debug prints (only on error)

a6fc7dc

releases only for tags starting with "r", fix for releases

708836b

single python file for workflow-related stuff: build always, release …

3bc4e96

…only if desired

nefarius2001 mentioned this pull request Jan 23, 2021

Automated build for Android APK #878

Closed

ann0see reviewed Jan 23, 2021

View reviewed changes

.github/workflows/autobuild.yml Show resolved Hide resolved

nefarius2001 added 6 commits January 23, 2021 22:06

fix & reaction to comments (do not build for all pushes, comments, fl…

dd2363f

…atpack-upload)

restrictive trigger & remove comments

d5ee1e5

new version of qt-install (supports multiple mirrors now)

a2a54de

re-apply nefarius2001-fixes to install-qt

2b0e949

Merge branch 'hash_in_verisoninfo'

71aafad

fix workflow py

bcffac3

ann0see requested changes Jan 24, 2021

View reviewed changes

Jamulus.pro Outdated Show resolved Hide resolved

android/automated_build/install-qt.sh Show resolved Hide resolved

Merge branch 'hash_in_verisoninfo' into auto_android_build_dev

09373d8

ann0see mentioned this pull request Jan 24, 2021

[Feature] Android installation explanation jamulussoftware/jamuluswebsite#264

Closed

Merge remote-tracking branch 'x_github_corrados/master' into auto_and…

96d66f8

…roid_build_dev

ann0see reviewed Jan 27, 2021

View reviewed changes

ann0see self-assigned this Jan 27, 2021

ann0see reviewed Jan 27, 2021

View reviewed changes

nefarius2001 added 2 commits January 28, 2021 01:02

add latest tag as trigger

d9bf12a

latest tag is not a prerelease

0f17f28

nefarius2001 force-pushed the auto_android_build branch from 7def6e6 to 0f17f28 Compare January 28, 2021 00:09

fix changelog

6ece598

ann0see approved these changes Jan 29, 2021

View reviewed changes

corrados merged commit 02d0785 into jamulussoftware:master Jan 29, 2021

pljones added this to the Release 3.7.0 milestone Nov 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Automated build for Android APK (updated) #880

Automated build for Android APK (updated) #880

nefarius2001 commented Jan 23, 2021

ann0see commented Jan 23, 2021

corrados commented Jan 24, 2021

ann0see left a comment

nefarius2001 commented Jan 24, 2021 •

edited

Loading

ann0see commented Jan 27, 2021

pljones commented Jan 27, 2021 •

edited

Loading

ann0see commented Jan 27, 2021 •

edited

Loading

ann0see Jan 27, 2021

nefarius2001 Jan 27, 2021

ann0see Jan 27, 2021

nefarius2001 Jan 27, 2021

ann0see Jan 28, 2021

ann0see commented Jan 27, 2021 •

edited

Loading

ann0see commented Jan 27, 2021

ann0see Jan 27, 2021

nefarius2001 Jan 28, 2021

nefarius2001 commented Jan 27, 2021 •

edited

Loading

pljones commented Jan 27, 2021

nefarius2001 commented Jan 28, 2021 •

edited

Loading

nefarius2001 commented Jan 28, 2021

corrados commented Jan 29, 2021

ann0see left a comment



		if pushed_name == "latest":
		print('this reference is a Latest-Tag')

Automated build for Android APK (updated) #880

Automated build for Android APK (updated) #880

Conversation

nefarius2001 commented Jan 23, 2021

ann0see commented Jan 23, 2021

corrados commented Jan 24, 2021

ann0see left a comment

Choose a reason for hiding this comment

nefarius2001 commented Jan 24, 2021 • edited Loading

ann0see commented Jan 27, 2021

pljones commented Jan 27, 2021 • edited Loading

ann0see commented Jan 27, 2021 • edited Loading

ann0see Jan 27, 2021

Choose a reason for hiding this comment

nefarius2001 Jan 27, 2021

Choose a reason for hiding this comment

ann0see Jan 27, 2021

Choose a reason for hiding this comment

nefarius2001 Jan 27, 2021

Choose a reason for hiding this comment

ann0see Jan 28, 2021

Choose a reason for hiding this comment

ann0see commented Jan 27, 2021 • edited Loading

ann0see commented Jan 27, 2021

ann0see Jan 27, 2021

Choose a reason for hiding this comment

nefarius2001 Jan 28, 2021

Choose a reason for hiding this comment

nefarius2001 commented Jan 27, 2021 • edited Loading

pljones commented Jan 27, 2021

nefarius2001 commented Jan 28, 2021 • edited Loading

nefarius2001 commented Jan 28, 2021

corrados commented Jan 29, 2021

ann0see left a comment

Choose a reason for hiding this comment

nefarius2001 commented Jan 24, 2021 •

edited

Loading

pljones commented Jan 27, 2021 •

edited

Loading

ann0see commented Jan 27, 2021 •

edited

Loading

ann0see commented Jan 27, 2021 •

edited

Loading

nefarius2001 commented Jan 27, 2021 •

edited

Loading

nefarius2001 commented Jan 28, 2021 •

edited

Loading