New windows installer #841
Conversation
The Powershell script provides the following improvements: - Automatic download of Jamulus dependencies (ASIOSDK, NSIS installer) - Automatic detection of Visual Studio/Build Tools installation (version 2017 and above) - Application packaging using Qt deployment tooling (windeployqt) - Easy execution from a standard Command Prompt as: powershell windows\deploy_windows.ps1 "<qt-install-path>"
The rework provides the following improvements: - Correct handling of 64bit and 32bit installations (registry keys, installation paths, disk space requirements) - Safer handling of installation path (only install into a new folder) - Update to Modern UI 2 installer experience - Support for internationalization (installer language selection and translations) - Fix broken detection of Jamulus already running (see https://sourceforge.net/p/llcon/discussion/software/thread/f3174d7f6f/) - Automatic detection of target files and folders to install
Update the Qt installer automation script to account for the latest changes in the installation process. The Qt online installer now requires a valid Qt user account. Also use the updated Windows deployment script.
Improve Windows deployment and CI process
The Powershell script provides the following improvements: - Automatic download of Jamulus dependencies (ASIOSDK, NSIS installer) - Automatic detection of Visual Studio/Build Tools installation (version 2017 and above) - Application packaging using Qt deployment tooling (windeployqt) - Easy execution from a standard Command Prompt as: powershell windows\deploy_windows.ps1 "<qt-install-path>"
The rework provides the following improvements: - Correct handling of 64bit and 32bit installations (registry keys, installation paths, disk space requirements) - Safer handling of installation path (only install into a new folder) - Update to Modern UI 2 installer experience - Support for internationalization (installer language selection and translations) - Fix broken detection of Jamulus already running (see https://sourceforge.net/p/llcon/discussion/software/thread/f3174d7f6f/) - Automatic detection of target files and folders to install
Update the Qt installer automation script to account for the latest changes in the installation process. The Qt online installer now requires a valid Qt user account. Also use the updated Windows deployment script.
Rebase improve_win_ci and fix a few bugs
New windows installer now checks if old version of Jamulus is wrongly installed
Ask user for Desktop shortcut
Win installer: make it possible to unselect desktop Shortcut
Automatically get mirror URL from SourceForge
|
|
|
Yes, 7zip works. But we have to use the integrated windows extraction tool which doesn’t seem to work. |
|
|
|
So I guess we can‘t do anything against that. Do you think powershell can unzip 7zip files natively (I doubt that)? This is needed since we can’t just install 7zip on the machine of a user who wants to compile jamulus. |
|
You could try renaming to 7z and seeing if the extractor can then deal with it... It may just be believing the extension rather than the data content. |
|
Sadly I can't see much in the way of "licence" information regarding the plug in - it's not clear if repackaging and hosting would be allowed. |
|
I doubt that windows supports 7zip natively (I read that it doesn't). You can follow the thread in the forum, I think it's possible to even make source code changes to it. But the license is not clear. |
|
Is it possible to download 7z in your script? |
|
Downloading is possible, but not unpacking. So it doesn't make sense. I think we can wait let's say a day or more and wait if there are comments in the forum post. I think we are allowed to host it somewhere else (just have a look at the forum post where someone even changed the code). |
|
Also have a look here: https://nsis.sourceforge.io/License
I hope this counts as NSIS plug-in. But it was written by 3 individuals, I think. |
The page title, "NsProcess plugin", pretty strongly indicates that it's a plug in. (Subject to random adjustments in hyphenation...) |
|
Ok. I've now uploaded a real zip file to the forum: http://forums.winamp.com/attachment.php?attachmentid=54705&d=1610882327 I don't really like the idea to host it there and would hope they allow us to upload it to jamulus.io or similar. |
|
I've now opened a PR. I hope we can host it on our own. |
Remove nsProcess and download it from forum
Yeah, seems a bit weak to have to have it in a forum post. Assuming the license is as stated - https://opensource.org/licenses/Zlib - then repackaging without alteration seems permissible. It's very open about what you can do. |
|
Should I merge this branch now? |
|
I think this should work since the most important todos are done. This will also fasciliate the windows autobuild. We can continue working on it of course. |
Created by @doloopuntil and @ann0see
There are still some open TODOs:
From #792
Blocking
1. Replace the graphics: The installer/uninstaller still uses the outdated logo --> Design team @geheimerEichkater @mulyaj @Erioldoesdesign (done)Non blocking
#792 (comment):
This is not yet done.
I don't want desktop shortcuts. Some people might want them, though.This is possible now.
I only want the 64bit version installed. And I want the default install location to be correct (not the 32bit location).This is done now
Would probably need a larger rewrite of the installer.nsi
I want to override what the install locations are.This should be possible now
To discuss. Is this blocking? Not yet sure how to do it exactly. (we remember if the user wants to install the desktop icon now) #860
Issue with spaces in build path: deploy_windows.ps1 doesn't work correctly if you run it in a path which contains spaces (not urgent); no idea how to solve it properly#864
Does the updated installer remove previous misplaced Jamulus x64 installations from C:\Program Files (x86)\Jamulus?Yes. Now it does after asking a user if he wants it.
There is still a bug which displays that the Jamulus installation is bigger than it in fact is. Probably it's the size of the 32 Bit and 64 Bit installation together(done #889)Detection of ASIO DriverWorks. @gilgongo: We need to add a short description of ASIO on the homepage: jamulussoftware/jamuluswebsite#242. Furthermore we need to improve the wording #861DoneWindows installer builds on GH Actions but the produced .exe file doesn't work on Windows 10 64 BitDone #853
Further language support(done #889)
Is this still needed? @pljones I think your codeql action is enough. (Should be migrated but not solved #863.)
#785
Not sure if can/should download the binaries. In the NSIS docs it says that a download in an installer might trigger anti-virus scanning software which is even worse.
Closes #792 #710