Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic build on release #828

Merged
merged 10 commits into from
Jan 11, 2021
Merged

Conversation

ann0see
Copy link
Member

@ann0see ann0see commented Jan 10, 2021

@corrados This should automatically build Jamlus for Debian and macOS via GitHub actions. Once the windows installer is merged, it should also publish the Windows installer to GitHub releases.

This sets the latest tag in a slightly different way, but it should work (I will do a final check by pushing a release tag Done).

See this release: https://github.com/ann0see/jamulus/releases/tag/latest

The resulting files haven’t been tested yet and I‘m struggling with finding a way to automatically get the content of the latest release of the ChangeLog file automatically.
Also the release seems to disappear once the latest tag is gone.

This was referenced Jan 10, 2021
@ann0see
Copy link
Member Author

ann0see commented Jan 11, 2021

macOS seems to work. Windows 64 Bit (at least from my fork) doesn't seem to work (error 0xc000007b) but Windows is not part of this PR.

@corrados
Copy link
Contributor

corrados commented Jan 11, 2021

I am curious, what are you trying to achieve? Do you want to automate the release process in a way that I only have to set the Git release tag and everything else is done automatically? That would be great :-)

I‘m struggling with finding a way to automatically get the content of the latest release of the ChangeLog

What about adding a marker in the ChangeLog like, e.g., this:

### 3.6.2 (2020-12-12)

So you could simply search for the "###"?

@corrados
Copy link
Contributor

corrados commented Jan 11, 2021

Or maybe use "##" [edit: ### should be just fine] and rename the ChangeLog to ChangeLog.md so that the lines are treated as headlines. What do you think?

@ann0see
Copy link
Member Author

ann0see commented Jan 11, 2021

Do you want to automate the release process in a way that I only have to set the Git release tag and everything else is done automatically?

That's the end goal, yes.

Nevertheless, I had some thoughts on this (just hypothetical):

  • There is a trust/security issue since we must then trust the GitHub runner. We don't know if it's somehow corrupted. If you compile it, we only have to trust you. Not sure if "reproducable builds" might solve this issue (I've only heared of this, but don't exactly know what it is).
  • How do we get the releases to SourceForge (can you do it manually)? This would also allow you to test if the releases really work.

What about adding a marker in the ChangeLog like, e.g., this:

Yes that would make it much easier. If somehow possible, I would prefer some kind of marker at the end of this line too (##) or |. So an entry could look like that:

## 4.0.0git <-- Note [...] ##
- Change 1
- Change 2
- Change 3

## 4.0.0 (0000-00-00) ##
- Change 1
- Change 2
- Change 3

The easiest to parse would be something like xml or similar, but that's not really user-friendly.

@ann0see
Copy link
Member Author

ann0see commented Jan 11, 2021

Tested the .deb files on Debian 10. Both work once you have jack installed. Should we add it as dependency?

The only remaining "problem" is Windows now. It might be due to a corrupted vs redist 64 bit.exe file. On my pc it seems to compile well, so I don't really get the problem for Windows. I hope once the runners are updated this issue is gone.

@corrados
Copy link
Contributor

Both work once you have jack installed. Should we add it as dependency?

The server does not need it. But I have no problem making it a dependency.

I have just added the markers to the ChangeLog file.

@corrados
Copy link
Contributor

BTW, is this pull request ready to be merged or do you want to do further changes?

@ann0see
Copy link
Member Author

ann0see commented Jan 11, 2021

Great! You can merge this PR and later I can add the changelog detection.

@corrados
Copy link
Contributor

Ok, thanks!

@corrados corrados merged commit 2653d34 into jamulussoftware:master Jan 11, 2021
@pljones pljones added this to the Release 3.7.0 milestone Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

3 participants