Win installer: Add ASIO detection #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
f865124 will also skip the download of nuget and VSSetup if they are not installed. I couldn't test what happens if they are not installed since I only have a Windows 8 VM which doesn't seem to support some commands used in this script. Can anybody confirm that this the installation of these dependencies still works? (I don't see any reasons why it shouldn't) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #821 is not yet ready, I think it makes sense to detect a missing ASIO driver.
Current behaviour:
If there's no ASIO key in the registry --> Show a page which links to jamulus.io
If the user exits this page and the key is still missing --> Show a warning where the user can descide if he wants to continue to install jamulus. This is needed since the server doesn't need an ASIO driver installed.