Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial working Android Code #661

Merged
merged 2 commits into from
Oct 5, 2020
Merged

Conversation

j-santander
Copy link
Contributor

This pull request contains code changes to the already existing android code solving some of the issues. It is linked to Issue #83.

It has been minimally tested on a Google Pixel 3a but I could listen to other participants and they could hear me.

Key things are:

  • Initialize the Oboe's FramesPerCallback to the proposed iNewPrefMonoBufferSize in CSound::Init()
  • Only set up with a callback the input/recording stream. The output/playing stream will be written directly (non-blocking) everytime we get a callback on the input. This matches how CClient does things.
  • Fixed the converstion from float to int16_t that previously resulted in the input being zero.
  • Added a second vector (float) to contain the reformatted output samples. Once the default format becomes float, this could go away.

I guess there's still a lot of work to do in the handling of error cases and possible variations in the oboe behaviour across different devices, but I hope this could be a starting point.

Please comment.

@j-santander j-santander mentioned this pull request Oct 5, 2020
@corrados
Copy link
Contributor

corrados commented Oct 5, 2020

Thanks. I'll merge it now and try it out on my Android phone.

@corrados corrados merged commit f62e058 into jamulussoftware:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants