-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add iOS Icon #3410
Add iOS Icon #3410
Conversation
I would prefer the icon to match the other platforms. We already have If you really need the icon with a blue square background, the white part of the image needs to move down a bit, to be vertically centred. |
Thanks. We should just try to follow https://developer.apple.com/design/human-interface-guidelines/app-icons |
I would personally prefer to only have the flash in white without the cloud and a blue background. However, I did not succeed to get only the flash out of the image. |
The icons are still not perfect, but I'd argue they better now. Also added iOS 18 dark and tinted icons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, those icons look fine. I see the CI built successfully with Qt5 (although a few code warnings). I don't know how to load the Unsigned IPA onto my iPad to test it.
As soon as this is merged, I'll create a new TestFlight build with the crash fix. |
Checkout sideloadly. It may not work with Qt5. https://gist.github.com/ann0see/8f354ed0ff154a2e9c47359eb8043020 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Icon from the new Testflight looks fine, so happy to approve.
I can't test it natively, but the screens look good to me. |
Please merge this PR if you think it's ok then. |
Short description of changes
To be able to deploy and test the iOS app on AppStore connect, an icon is needed (#2625 (comment)). I just went the easiest way and created an (ugly version of) the main icon for iOS. This may or may not work with Qt5 builds.
CHANGELOG: iOS: Add icon to iOS app
Context: Fixes an issue?
Not directly. However, having an icon is necessary.
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready for review. Need to check if the Qt5 build fails or not.
What is missing until this pull request can be merged?
Checklist