Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iOS Icon #3410

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Add iOS Icon #3410

merged 1 commit into from
Oct 25, 2024

Conversation

ann0see
Copy link
Member

@ann0see ann0see commented Oct 12, 2024

Short description of changes

To be able to deploy and test the iOS app on AppStore connect, an icon is needed (#2625 (comment)). I just went the easiest way and created an (ugly version of) the main icon for iOS. This may or may not work with Qt5 builds.
CHANGELOG: iOS: Add icon to iOS app
Context: Fixes an issue?

Not directly. However, having an icon is necessary.
Does this change need documentation? What needs to be documented and how?

No
Status of this Pull Request
Ready for review. Need to check if the Qt5 build fails or not.

What is missing until this pull request can be merged?

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want (Qt6 build only, Qt5 will fail or not on GitHub)
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@ann0see ann0see added iOS iOS runtime issue Mobile UI Issues with the UI on mobile platforms labels Oct 12, 2024
@ann0see ann0see added this to the Release 3.12.0 milestone Oct 12, 2024
@ann0see
Copy link
Member Author

ann0see commented Oct 13, 2024

icon Jamulus iOS screenshot

As screenshot.

We'd need a @jamulussoftware/designers who makes this one nice.

@ann0see
Copy link
Member Author

ann0see commented Oct 14, 2024

@softins @gilgongo could you please also have a look at this one? I'd like to get this in also for iOS support. This makes building with TestFlight easier (as AppStore connect requires an icon)

@softins
Copy link
Member

softins commented Oct 17, 2024

I would prefer the icon to match the other platforms. We already have src/res/io.jamulus.jamulus.png, src/res/fronticon.png and src/res/win-mainicon.ico. Putting one of those designs on a white rounded square would look better, I think. That's what "AIM Jamulus" did:

image

If you really need the icon with a blue square background, the white part of the image needs to move down a bit, to be vertically centred.

@ann0see
Copy link
Member Author

ann0see commented Oct 17, 2024

Thanks.
It absolutely doesn't need to be how it is currently.

We should just try to follow https://developer.apple.com/design/human-interface-guidelines/app-icons

@ann0see
Copy link
Member Author

ann0see commented Oct 17, 2024

I would personally prefer to only have the flash in white without the cloud and a blue background. However, I did not succeed to get only the flash out of the image.

@ann0see
Copy link
Member Author

ann0see commented Oct 17, 2024

The icons are still not perfect, but I'd argue they better now. Also added iOS 18 dark and tinted icons. I cannot test those. Tested via Simulator. See below. For the standard one, I'll check later tonight.

@ann0see
Copy link
Member Author

ann0see commented Oct 17, 2024

iOS Icon

On iOS 17

@ann0see
Copy link
Member Author

ann0see commented Oct 17, 2024

Photos from the simulator on iOS 18 with new icons.

Simulator Screenshot - iPhone 16 Pro - 2024-10-17 at 23 15 38
Simulator Screenshot - iPhone 16 Pro - 2024-10-17 at 23 15 53

Simulator Screenshot - iPhone 16 Pro - 2024-10-17 at 23 16 00

Copy link
Member

@softins softins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, those icons look fine. I see the CI built successfully with Qt5 (although a few code warnings). I don't know how to load the Unsigned IPA onto my iPad to test it.

@ann0see
Copy link
Member Author

ann0see commented Oct 19, 2024

As soon as this is merged, I'll create a new TestFlight build with the crash fix.

@ann0see ann0see requested a review from pljones October 19, 2024 17:02
@ann0see
Copy link
Member Author

ann0see commented Oct 19, 2024

I don't know how to load the Unsigned IPA onto my iPad to test it.

Checkout sideloadly. It may not work with Qt5.

https://gist.github.com/ann0see/8f354ed0ff154a2e9c47359eb8043020

@ann0see ann0see requested review from gilgongo and removed request for gilgongo October 21, 2024 20:16
Copy link
Member

@softins softins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon from the new Testflight looks fine, so happy to approve.

@ann0see
Copy link
Member Author

ann0see commented Oct 24, 2024

@gilgongo @pljones Could you please have a look at this?

@gilgongo
Copy link
Member

I can't test it natively, but the screens look good to me.

@ann0see
Copy link
Member Author

ann0see commented Oct 25, 2024

Please merge this PR if you think it's ok then.

@gilgongo gilgongo merged commit 85ca8a5 into jamulussoftware:main Oct 25, 2024
12 checks passed
@ann0see ann0see deleted the iOS/AddIcon branch October 25, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS iOS runtime issue Mobile UI Issues with the UI on mobile platforms
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants