Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Generate qm files and embedded resource during build #3288

Merged
merged 4 commits into from
Jun 22, 2024

Commits on Jun 16, 2024

  1. Remove .qm files from repo and auto-build them

    Previously, translations were embedded manually, via src/resources.qrc
    
    Now they are compiled and embedded automatically, using embed_translations,
    which allows them to be correctly located for multiple targets or archs.
    
    Note that RCC_DIR and LRELEASE_DIR can no longer be specified, because the
    system defaults are necessary for multiple targets/archs to build correctly.
    
    The version of Qt must be at least 5.12 for lrelease and embed_translations.
    softins committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    1b40e4f View commit details
    Browse the repository at this point in the history
  2. Update getting language identifier from filename

    The resources generated by embed_translations include the .qm from
    the filename in the resource name, so it is necessary to remove it.
    Also, the prefix generated by qmake is /i18n, not /translations.
    softins committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    85b6f0d View commit details
    Browse the repository at this point in the history
  3. Remove separate lrelease for linux

    Now that the .qm files are generated on the fly by the Makefile,
    a manual lrelease step is no longer needed and wouldn't work correctly.
    softins committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    05789c6 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. Configuration menu
    Copy the full SHA
    97306e7 View commit details
    Browse the repository at this point in the history