Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Bump aqt from 2.1.0 to 2.2.3 (Automated PR) #2814

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

github-actions[bot]
Copy link

This automated Pull Request updates the used aqt version to version 2.2.3.

This PR was opened by the workflow Bump dependencies (create-prs)

CHANGELOG: SKIP

@hoffie hoffie force-pushed the ci/bump-dependencies/aqt branch from f74dc4f to c61eba4 Compare August 28, 2022 19:17
@ann0see
Copy link
Member

ann0see commented Aug 28, 2022

@hoffie did you really force-push this PR or is that just due to the fact that you created the ssh key?

@hoffie
Copy link
Member

hoffie commented Aug 28, 2022

due to the fact that you created the ssh key?

Seems to be this. :(

@ann0see
Copy link
Member

ann0see commented Aug 28, 2022

It's mainly a cosmetic thing, but still strange. Does this key include your E-Mail address?

In theory we could create a SSH key on a runner, by connecting to it via SSH, retrieving it and then uploading it as secret.

@hoffie
Copy link
Member

hoffie commented Aug 28, 2022

It's mainly a cosmetic thing, but still strange. Does this key include your E-Mail address?

No. Even if it did, the mail address would only be part of the comment field which isn't transmitted when authenticating.

In theory we could create a SSH key on a runner, by connecting to it via SSH, retrieving it and then uploading it as secret.

This wouldn't help. The association comes from a Github feature -- the user who adds it is recorded. If you were to add the same key, it would be you instead. I'm not exactly happy about that, maybe we are back at the Should-we-have-a-machine-user thought process. :/

@hoffie hoffie added this to the Release 3.9.1 milestone Aug 28, 2022
@ann0see
Copy link
Member

ann0see commented Aug 28, 2022

Hmm. I mean, we do have @jamulusold. Its password is shared with @gilgongo and maybe @gene96817 (which I don't think) #1985

@hoffie hoffie force-pushed the ci/bump-dependencies/aqt branch from c61eba4 to d432241 Compare August 29, 2022 13:02
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok to merge?

Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.

@hoffie hoffie merged commit 718d0d7 into master Aug 29, 2022
@github-actions github-actions bot deleted the ci/bump-dependencies/aqt branch August 29, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants