-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Bump aqt from 2.1.0 to 2.2.3 (Automated PR) #2814
Conversation
f74dc4f
to
c61eba4
Compare
@hoffie did you really force-push this PR or is that just due to the fact that you created the ssh key? |
Seems to be this. :( |
It's mainly a cosmetic thing, but still strange. Does this key include your E-Mail address? In theory we could create a SSH key on a runner, by connecting to it via SSH, retrieving it and then uploading it as secret. |
No. Even if it did, the mail address would only be part of the comment field which isn't transmitted when authenticating.
This wouldn't help. The association comes from a Github feature -- the user who adds it is recorded. If you were to add the same key, it would be you instead. I'm not exactly happy about that, maybe we are back at the Should-we-have-a-machine-user thought process. :/ |
Hmm. I mean, we do have @jamulusold. Its password is shared with @gilgongo and maybe @gene96817 (which I don't think) #1985 |
c61eba4
to
d432241
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's ok to merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep.
This automated Pull Request updates the used aqt version to version 2.2.3.
This PR was opened by the workflow Bump dependencies (create-prs)
CHANGELOG: SKIP