Upgrade create-dmg to latest version 1.1.0 #2664
Conversation
hoffie
changed the title
There was a problem hiding this comment.
Looks good. Proper create-dmg version has been installed, build is green. Can't do any other Mac tests though.
ann0see
force-pushed
the
upgradeCreate-DMG
branch
from
065c740 to
c88680c
Compare
|
I'll test it once the CI has compiled again. |
|
Ok. Tested the old build (with the wrong commit message) and it installs as before on macOS |
|
Do we know why this is happening (was on 1.0.9, too) - happens just after the create-dmg run line: I take it there's no reason why this would affect the supported legacy MacOS version as it's just the DMG packaging? |
|
Since nothing big changes (only disabled support for more modern compression and signing), nothing changes for now. |
|
No, I don't know about this error |
|
@pljones Another minor fix here. |
|
Where? |
|
Upgrade was changed to upgraded |
|
Just to note: as I'm editing these by hand (I'd have to delete them all and start again otherwise, losing all the edits I've already done), it's clearer to state the change you're suggesting than making it. |
|
Ok. Will do that in future. |
I'd like to have this in 3.9.0
Short description of changes
Upgrades create-dmg to the latest version. Nothing changed (especially this PR does not change the compression format)
CHANGELOG: Mac: Upgraded create-dmg to the latest version
Context: Fixes an issue?
No. Related to: #2663
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Ready for second review.
What is missing until this pull request can be merged?
CI and testing
Checklist