A11y: Combine client info into a group #2638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Is it that easy? |
|
Yes!!!
|
hoffie
reviewed
May 22, 2022
| @@ -862,6 +862,8 @@ void CChannelFader::SetChannelInfos ( const CChannelInfo& cChanInfo ) | |||
| plblLabel->setToolTip ( strToolTip ); | |||
| plblLabel->setAccessibleName ( strAliasAccessible ); | |||
| plblLabel->setAccessibleDescription ( tr ( "Alias" ) ); | |||
| dynamic_cast<QWidget*> ( plblLabel->parent() ) | |||
There was a problem hiding this comment.
Just trying to understand why the cast is needed:
- This is in
CChannelFaderwhich is aQObject. Therefore,parent()returns aQObjectas well. - Doing the dynamic_cast is safe and right to do because we know that
CChannelFaderis only used as a child inCAudioMixerBoard, which is aQWidget.
Is that correct? If so, would it make sense to add a short code comment about that?
There was a problem hiding this comment.
Most UI things are widgets. But if parent (i.e. the form it's stuck to) is only declared as a QObject, you'll get told off by the compiler trying to use methods QObject doesn't have -- even though the QObject you're talking about does have them. Hence the cast. So long as it's viable (I've not checked).
|
In order to ->setAccessibleDescription, you need to cast to QWidget.
|
ann0see
reviewed
May 27, 2022
|
You can check with a screen reader. VoiceOver on Mac, and NVDA with
object navigation on Windows.
VoiceOver has a mini tutorial how to use it if you press command+f5 on
your Mac.
|
|
Ok. Thanks. Could hear it now. The integrated one of Win 11 didn't find it |
ann0see
requested changes
May 29, 2022
pljones
approved these changes
May 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Combine all the client info, so screen reader users don't have to track down multiple places.
CHANGELOG: Accessibility: Combine all the client info, so screen reader users don't have to track down multiple places.
Context: Fixes an issue?
Does this change need documentation? What needs to be documented and how?
Status of this Pull Request
What is missing until this pull request can be merged?
Checklist